[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2894: Start KDE Cleanups
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-09-30 15:35:37
Message-ID: 20160930153537.79323.9684.82F1C307 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in startkde.cmake:153
> Yes.
> 
> David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths GenericConfigLocation
> /home/david/.config:/opt/kde5/etc/xdg::/etc/xdg
> 
> David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths ConfigLocation 
> /home/david/.config:/opt/kde5/etc/xdg::/etc/xdg
> 
> The change doens't actually acheive much
> 
> So we still need the tr and sed to turn it into
> 
> /home/david/.config/plasma-workspace
> /opt/kde5/etc/xdg/plasma-workspace
> /etc/xdg/plasma-workspace

Edit!

I can make this better. See next patch

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2894

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2894" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D2894#inline-11246" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; \
font-weight: bold;">startkde.cmake:153</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Yes.</p>

<p style="padding: 0; margin: \
8px;">David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths \
                GenericConfigLocation<br />
/home/david/.config:/opt/kde5/etc/xdg::/etc/xdg</p>

<p style="padding: 0; margin: \
8px;">David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths \
                ConfigLocation <br />
/home/david/.config:/opt/kde5/etc/xdg::/etc/xdg</p>

<p style="padding: 0; margin: 8px;">The change doens&#039;t actually \
acheive much</p>

<p style="padding: 0; margin: 8px;">So we still need the tr and sed to turn \
it into</p>

<p style="padding: 0; margin: 8px;">/home/david/.config/plasma-workspace<br \
                />
/opt/kde5/etc/xdg/plasma-workspace<br />
/etc/xdg/plasma-workspace</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Edit!</p>

<p style="padding: 0; margin: 8px;">I can make this better. See next \
patch</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D2894" \
rel="noreferrer">https://phabricator.kde.org/D2894</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]