From kde-panel-devel  Fri Sep 30 15:35:37 2016
From: "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date: Fri, 30 Sep 2016 15:35:37 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D2894: Start KDE Cleanups
Message-Id: <20160930153537.79323.9684.82F1C307 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147524975028708
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--aeac9c2c248442e19e1e5505d0386bb0"

--aeac9c2c248442e19e1e5505d0386bb0
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in startkde.cmake:153
> Yes.
> 
> David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths GenericConfigLocation
> /home/david/.config:/opt/kde5/etc/xdg::/etc/xdg
> 
> David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths ConfigLocation 
> /home/david/.config:/opt/kde5/etc/xdg::/etc/xdg
> 
> The change doens't actually acheive much
> 
> So we still need the tr and sed to turn it into
> 
> /home/david/.config/plasma-workspace
> /opt/kde5/etc/xdg/plasma-workspace
> /etc/xdg/plasma-workspace

Edit!

I can make this better. See next patch

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2894

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--aeac9c2c248442e19e1e5505d0386bb0
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">davidedmundson=20added=20inline=20comments.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D2894"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=
=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20=
border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F=
7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=
=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20backgro=
und:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=
=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://phabricat=
or.kde.org/D2894#inline-11246"=20rel=3D"noreferrer">View=20Inline</a><span=
=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">davidedmundson</span>=
=20wrote=20in=20<span=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">=
startkde.cmake:153</span></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;=20color:=20#74777=
D;"><p=20style=3D"padding:=200;=20margin:=208px;">Yes.</p>

<p=20style=3D"padding:=200;=20margin:=208px;">David-Desktop:~/projects/kde5=
/src/kde/workspace=20$=20qtpaths=20--paths=20GenericConfigLocation<br=20/>
/home/david/.config:/opt/kde5/etc/xdg::/etc/xdg</p>

<p=20style=3D"padding:=200;=20margin:=208px;">David-Desktop:~/projects/kde5=
/src/kde/workspace=20$=20qtpaths=20--paths=20ConfigLocation=20<br=20/>
/home/david/.config:/opt/kde5/etc/xdg::/etc/xdg</p>

<p=20style=3D"padding:=200;=20margin:=208px;">The=20change=20doens&#039;t=
=20actually=20acheive=20much</p>

<p=20style=3D"padding:=200;=20margin:=208px;">So=20we=20still=20need=20the=
=20tr=20and=20sed=20to=20turn=20it=20into</p>

<p=20style=3D"padding:=200;=20margin:=208px;">/home/david/.config/plasma-wo=
rkspace<br=20/>
/opt/kde5/etc/xdg/plasma-workspace<br=20/>
/etc/xdg/plasma-workspace</p></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">Edit!</p>

<p=20style=3D"padding:=200;=20margin:=208px;">I=20can=20make=20this=20bette=
r.=20See=20next=20patch</p></div></div></div></div></div><br=20/><div><stro=
ng>REPOSITORY</strong><div><div>rPLASMAWORKSPACE=20Plasma=20Workspace</div>=
</div></div><br=20/><div><strong>REVISION=20DETAIL</strong><div><a=20href=
=3D"https://phabricator.kde.org/D2894"=20rel=3D"noreferrer">https://phabric=
ator.kde.org/D2894</a></div></div><br=20/><div><strong>EMAIL=20PREFERENCES<=
/strong><div><a=20href=3D"https://phabricator.kde.org/settings/panel/emailp=
references/"=20rel=3D"noreferrer">https://phabricator.kde.org/settings/pane=
l/emailpreferences/</a></div></div><br=20/><div><strong>To:=20</strong>davi=
dedmundson,=20Plasma<br=20/><strong>Cc:=20</strong>broulik,=20plasma-devel,=
=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20sebas<br=20/></=
div>
--aeac9c2c248442e19e1e5505d0386bb0--