[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Changed Subscribers] D2894: Start KDE Cleanups
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: 2016-09-30 15:19:22
Message-ID: 20160930151919.95234.40822.61A3959E () phabricator ! kde ! org
[Download RAW message or body]
broulik added inline comments.
INLINE COMMENTS
> startkde.cmake:6
>
> -if test "x$1" = x--failsafe; then
> - KDE_FAILSAFE=1 # General failsafe flag
Don't we install an "kde failsafe" x session which uses that?
> startkde.cmake:153
>
> -# TODO: Use GenericConfigLocation once we depend on Qt 5.4
> -scriptpath=`qtpaths --paths ConfigLocation | tr ':' '\n' | sed 's,$,/plasma-workspace,g'`
> +scriptpath=`qtpaths --paths GenericConfigLocation | tr ':' '\n' | sed 's,$,/plasma-workspace,g'`
>
Is that see still needed/correct with generic config location?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2894
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2894" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2894#inline-11244" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">startkde.cmake:6</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;"><span class="err">if</span> <span class="err">test</span> <span \
class="err">"x$1"</span> <span class="err">=</span> <span \
class="err">x--failsafe;</span> <span class="err">then</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span \
class="err">KDE_FAILSAFE=1</span> <span style="color: #74777d"># General failsafe \
flag</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Don't we install an "kde failsafe" x session which uses \
that?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2894#inline-11243" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">startkde.cmake:153</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;"><span class="bright"></span><span style="color: #74777d"><span \
class="bright"># TODO: Use GenericConfigLocation once we depend on Qt \
5.4</span></span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;"><span class="err">scriptpath=`qtpaths</span> <span \
class="err">--paths</span> <span class="err">ConfigLocation</span> <span \
class="err">|</span> <span class="err">tr</span> <span class="err">':'</span> \
<span class="err">'\n'</span> <span class="err">|</span> <span \
class="err">sed</span> <span class="err">'s,$,/plasma-workspace,g'`</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span \
class="bright"></span><span class="err"><span \
class="bright">scriptpath=`qtpaths</span></span><span class="bright"> </span><span \
class="err"><span class="bright">--paths</span></span><span class="bright"> \
</span><span class="err"><span \
class="bright">GenericConfigLocation</span></span><span class="bright"> </span><span \
class="err"><span class="bright">|</span></span><span class="bright"> </span><span \
class="err"><span class="bright">tr</span></span><span class="bright"> </span><span \
class="err"><span class="bright">':'</span></span><span class="bright"> \
</span><span class="err"><span class="bright">'\n'</span></span><span \
class="bright"> </span><span class="err"><span class="bright">|</span></span><span \
class="bright"> </span><span class="err"><span class="bright">sed</span></span><span \
class="bright"> </span><span class="err"><span \
class="bright">'s,$,/plasma-workspace,g'`</span></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is \
that see still needed/correct with generic config \
location?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2894" \
rel="noreferrer">https://phabricator.kde.org/D2894</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic