From kde-panel-devel  Fri Sep 30 15:19:22 2016
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: Fri, 30 Sep 2016 15:19:22 +0000
To: kde-panel-devel
Subject: [Differential] [Changed Subscribers] D2894: Start KDE Cleanups
Message-Id: <20160930151919.95234.40822.61A3959E () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147524878028292
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--02b9229d19c94b5ca7e1bda86e9e5800"

--02b9229d19c94b5ca7e1bda86e9e5800
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

broulik added inline comments.

INLINE COMMENTS

> startkde.cmake:6
>  
> -if test "x$1" = x--failsafe; then
> -    KDE_FAILSAFE=1 # General failsafe flag

Don't we install an "kde failsafe" x session which uses that?

> startkde.cmake:153
>  
> -# TODO: Use GenericConfigLocation once we depend on Qt 5.4
> -scriptpath=`qtpaths --paths ConfigLocation | tr ':' '\n' | sed 's,$,/plasma-workspace,g'`
> +scriptpath=`qtpaths --paths GenericConfigLocation | tr ':' '\n' | sed 's,$,/plasma-workspace,g'`
>  

Is that see still needed/correct with generic config location?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2894

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--02b9229d19c94b5ca7e1bda86e9e5800
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">broulik=20added=20inline=20comments.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D2894"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=
=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20=
border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F=
7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=
=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20backgro=
und:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=
=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://phabricat=
or.kde.org/D2894#inline-11244"=20rel=3D"noreferrer">View=20Inline</a><span=
=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">startkde.cmake:6</spa=
n></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#ffd0d0;"><span=20class=3D"err=
">if</span>=20<span=20class=3D"err">test</span>=20<span=20class=3D"err">&qu=
ot;x$1&quot;</span>=20<span=20class=3D"err">=3D</span>=20<span=20class=3D"e=
rr">x--failsafe;</span>=20<span=20class=3D"err">then</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20class=3D"err">KDE_FAILSAFE=3D1</span>=20<=
span=20style=3D"color:=20#74777d">#=20General=20failsafe=20flag</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">Don&#039;t=20we=20install=20an=20&quot;kde=20=
failsafe&quot;=20x=20session=20which=20uses=20that?</p></div></div><br=20/>=
<div=20style=3D"border:=201px=20solid=20#C7CCD9;=20border-radius:=203px;"><=
div=20style=3D"padding:=200;=20background:=20#F7F7F7;=20border-color:=20#e3=
e4e8;=20border-style:=20solid;=20border-width:=200=200=201px=200;=20margin:=
=200;"><div=20style=3D"color:=20#74777d;=20background:=20#eff2f4;=20padding=
:=206px=208px;=20overflow:=20hidden;"><a=20style=3D"float:=20right;=20text-=
decoration:=20none;"=20href=3D"https://phabricator.kde.org/D2894#inline-112=
43"=20rel=3D"noreferrer">View=20Inline</a><span=20style=3D"color:=20#4b4d51=
;=20font-weight:=20bold;">startkde.cmake:153</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#ffd0d0;"><span=20class=3D"bri=
ght"></span><span=20style=3D"color:=20#74777d"><span=20class=3D"bright">#=
=20TODO:=20Use=20GenericConfigLocation=20once=20we=20depend=20on=20Qt=205.4=
</span></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;"><span=20class=3D"err">scriptpath=3D`qtpaths</span>=20<span=20=
class=3D"err">--paths</span>=20<span=20class=3D"err">ConfigLocation</span>=
=20<span=20class=3D"err">|</span>=20<span=20class=3D"err">tr</span>=20<span=
=20class=3D"err">&#39;:&#39;</span>=20<span=20class=3D"err">&#39;\n&#39;</s=
pan>=20<span=20class=3D"err">|</span>=20<span=20class=3D"err">sed</span>=20=
<span=20class=3D"err">&#39;s,$,/plasma-workspace,g&#39;`</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;"><span=20class=3D"bright"></span><span=20class=3D"err"><span=
=20class=3D"bright">scriptpath=3D`qtpaths</span></span><span=20class=3D"bri=
ght">=20</span><span=20class=3D"err"><span=20class=3D"bright">--paths</span=
></span><span=20class=3D"bright">=20</span><span=20class=3D"err"><span=20cl=
ass=3D"bright">GenericConfigLocation</span></span><span=20class=3D"bright">=
=20</span><span=20class=3D"err"><span=20class=3D"bright">|</span></span><sp=
an=20class=3D"bright">=20</span><span=20class=3D"err"><span=20class=3D"brig=
ht">tr</span></span><span=20class=3D"bright">=20</span><span=20class=3D"err=
"><span=20class=3D"bright">&#39;:&#39;</span></span><span=20class=3D"bright=
">=20</span><span=20class=3D"err"><span=20class=3D"bright">&#39;\n&#39;</sp=
an></span><span=20class=3D"bright">=20</span><span=20class=3D"err"><span=20=
class=3D"bright">|</span></span><span=20class=3D"bright">=20</span><span=20=
class=3D"err"><span=20class=3D"bright">sed</span></span><span=20class=3D"br=
ight">=20</span><span=20class=3D"err"><span=20class=3D"bright">&#39;s,$,/pl=
asma-workspace,g&#39;`</span></span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">Is=20that=20see=20still=20needed/correct=20wi=
th=20generic=20config=20location?</p></div></div></div></div></div><br=20/>=
<div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE=20Plasma=20Works=
pace</div></div></div><br=20/><div><strong>REVISION=20DETAIL</strong><div><=
a=20href=3D"https://phabricator.kde.org/D2894"=20rel=3D"noreferrer">https:/=
/phabricator.kde.org/D2894</a></div></div><br=20/><div><strong>EMAIL=20PREF=
ERENCES</strong><div><a=20href=3D"https://phabricator.kde.org/settings/pane=
l/emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kde.org/setti=
ngs/panel/emailpreferences/</a></div></div><br=20/><div><strong>To:=20</str=
ong>davidedmundson,=20Plasma<br=20/><strong>Cc:=20</strong>broulik,=20plasm=
a-devel,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20sebas<b=
r=20/></div>
--02b9229d19c94b5ca7e1bda86e9e5800--