[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2882: Don't load QPT in kcminit
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-09-28 19:59:13
Message-ID: 20160928195910.79425.36624.358E72A5 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> main.cpp:256
> QGuiApplication app(argc, argv); //gui is needed for several modules
> +  app.setDesktopSettingsAware(false);
> KAboutData about(QStringLiteral("kcminit"), i18n("KCMInit"), QString(),

This is a static and docs explicitly mention "This function must be called before \
creating the QGuiApplication object",

http://doc.qt.io/qt-5/qguiapplication.html#setDesktopSettingsAware

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2882

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, bshah
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2882" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2882#inline-11199" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">main.cpp:256</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  \
<span class="n">QGuiApplication</span> <span style="color: #004012">app</span><span \
class="p">(</span><span class="n">argc</span><span class="p">,</span> <span \
class="n">argv</span><span class="p">);</span> <span style="color: #74777d">//gui is \
needed for several modules</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">  <span class="n">app</span><span class="p">.</span><span \
class="n">setDesktopSettingsAware</span><span class="p">(</span><span style="color: \
#304a96">false</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">  <span class="n">KAboutData</span> <span style="color: \
#004012">about</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">&quot;kcminit&quot;</span><span class="p">),</span> <span \
class="n">i18n</span><span class="p">(</span><span style="color: \
#766510">&quot;KCMInit&quot;</span><span class="p">),</span> <span \
class="n">QString</span><span class="p">(),</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
is a static and docs explicitly mention &quot;This function must be called before \
creating the QGuiApplication object&quot;,</p>

<p style="padding: 0; margin: 8px;"><a \
href="http://doc.qt.io/qt-5/qguiapplication.html#setDesktopSettingsAware" \
class="remarkup-link" target="_blank" \
rel="noreferrer">http://doc.qt.io/qt-5/qguiapplication.html#setDesktopSettingsAware</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2882" \
rel="noreferrer">https://phabricator.kde.org/D2882</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, bshah<br /><strong>Cc: \
</strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]