[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Changed Subscribers] D2877: Use Plasma::PluginLoader to list applets
From: "apol (Aleix Pol Gonzalez)" <noreply () phabricator ! kde ! org>
Date: 2016-09-27 22:12:31
Message-ID: 20160927221229.26035.48099.9C811E7A () phabricator ! kde ! org
[Download RAW message or body]
apol added inline comments.
INLINE COMMENTS
> widgetexplorer.cpp:135
> QStringList cats;
> - const QList<KPluginMetaData> list = \
> KPackage::PackageLoader::self()->listPackages(QStringLiteral("Plasma/Applet"), \
> QStringLiteral("plasma/plasmoids")); + const QList<KPluginInfo> list = \
> PluginLoader::self()->listAppletInfo(QString());
shouldn't `listAppletInfo` be returning a `QList<KPluginMetaData>`?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2877
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2877" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2877#inline-11178" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">widgetexplorer.cpp:135</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="n">QStringList</span> <span \
class="n">cats</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">const</span> \
<span class="n">QList</span><span style="color: #aa2211"><</span><span \
class="n">KPlugin<span class="bright">MetaData</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">></span></span><span class="bright"> </span><span class="n"><span \
class="bright">list</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">=</span></span><span class="bright"> </span><span \
class="n"><span class="bright">KPackage</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">PackageLoader</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span class="bright">self</span></span><span \
class="bright"></span><span class="p"><span class="bright">()</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">listPackages</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">QStringLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"Plasma/Applet"</span></span><span \
class="bright"></span><span class="p"><span class="bright">),</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span \
class="bright">"plasma/plasmoids"</span></span><span class="p">));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
style="color: #aa4000">const</span> <span class="n">QList</span><span style="color: \
#aa2211"><</span><span class="n">KPlugin<span \
class="bright">Info</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">></span></span><span class="bright"> </span><span \
class="n"><span class="bright">list</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span class="n"><span class="bright">PluginLoader</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">self</span></span><span class="bright"></span><span class="p"><span \
class="bright">()</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">listAppletInfo</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span class="bright">QString</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span>));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">shouldn't <tt style="background: #ebebeb; font-size: \
13px;">listAppletInfo</tt> be returning a <tt style="background: #ebebeb; font-size: \
13px;">QList<KPluginMetaData></tt>?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2877" \
rel="noreferrer">https://phabricator.kde.org/D2877</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>apol, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic