[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2853: Mouse KCM: Align spin boxes, port to Qt5
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-09-26 9:06:48
Message-ID: 20160926090648.24626.33251.F20A0ACE () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> mouse.cpp:796
> +  foreach (QObject *obj, children) {
> +    QAbstractSpinBox *field = qobject_cast<QAbstractSpinBox *>(obj);
> +    if (field != NULL) {

not sure about this manual resize.
couldn't the kcm just have used a gridlayout instead?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2853

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2853" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2853#inline-11124" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mouse.cpp:796</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">  <span class="n">foreach</span> <span class="p">(</span><span \
class="n">QObject</span> <span style="color: #aa2211">*</span><span \
class="n">obj</span><span class="p">,</span> <span class="n">children</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;">    <span class="n">QAbstractSpinBox</span> <span \
style="color: #aa2211">*</span><span class="n">field</span> <span style="color: \
#aa2211">=</span> <span class="n">qobject_cast</span><span style="color: \
#aa2211">&lt;</span><span class="n">QAbstractSpinBox</span> <span style="color: \
#aa2211">*&gt;</span><span class="p">(</span><span class="n">obj</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">field</span> <span style="color: #aa2211">!=</span> <span style="color: \
#304a96">NULL</span><span class="p">)</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">not sure about this manual resize.<br /> couldn&#039;t the kcm just \
have used a gridlayout instead?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2853" \
rel="noreferrer">https://phabricator.kde.org/D2853</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>marten, Plasma<br /><strong>Cc: </strong>mart, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]