[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2850: Prevent "TypeError: Cannot read property 'Layout' of nul
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-09-26 9:05:27
Message-ID: 20160926090527.24574.32825.6978EF70 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> Panel.qml:79
> when: containment
> value: {
> +            if (!containment) {

The binding is still evaluated and a value assigned to "value", it's just that \
Binding {} won't propagate it to its target when "when" doesn't evaluate true.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2850

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: eliasp, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2850" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2850#inline-11123" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">Panel.qml:79</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #aa4000">when:</span> <span style="color: \
#004012">containment</span> </div><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #aa4000">value:</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span style="color: #004012">containment</span><span \
class="p">)</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The \
binding is still evaluated and a value assigned to &quot;value&quot;, it&#039;s just \
that Binding {} won&#039;t propagate it to its target when &quot;when&quot; \
doesn&#039;t evaluate true.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2850" \
rel="noreferrer">https://phabricator.kde.org/D2850</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>eliasp, Plasma, davidedmundson<br /><strong>Cc: \
</strong>broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]