[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Changed Subscribers] D2630: Support highlighting windows through EffectsHandlerImpl
From: sebas_(Sebastian_Kügler) <noreply () phabricator ! kde ! org>
Date: 2016-09-12 20:09:53
Message-ID: 20160912200952.20970.95336.71C15CC4 () phabricator ! kde ! org
[Download RAW message or body]
sebas added inline comments.
INLINE COMMENTS
> effects.h:239
>
> + void highlightWindows(const QVector<EffectWindow *> &windows);
> +
EffectWindow* ?
> highlightwindow.cpp:261
>
> +void HighlightWindowEffect::highlightWindows(const QVector<KWin::EffectWindow *> &windows)
> +{
whitespace
> highlightwindow.h:58
>
> + void highlightWindows(const QVector<KWin::EffectWindow *> &windows);
> +
EffectWindow* (no space)
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D2630
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: sebas, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts
[Attachment #3 (text/html)]
<table><tr><td style="">sebas added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2630" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2630#inline-10767" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">effects.h:239</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">void</span> <span \
style="color: #004012">highlightWindows</span><span class="p">(</span><span \
style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: \
#aa2211"><</span><span class="n">EffectWindow</span> <span style="color: \
#aa2211">*></span> <span style="color: #aa2211">&</span><span \
class="n">windows</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">EffectWindow* ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D2630#inline-10769" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">highlightwindow.cpp:261</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"><span style="color: #aa4000">void</span> <span \
class="n">HighlightWindowEffect</span><span style="color: #aa2211">::</span><span \
class="n">highlightWindows</span><span class="p">(</span><span style="color: \
#aa4000">const</span> <span class="n">QVector</span><span style="color: \
#aa2211"><</span><span class="n">KWin</span><span style="color: \
#aa2211">::</span><span class="n">EffectWindow</span> <span style="color: \
#aa2211">*></span> <span style="color: #aa2211">&</span><span \
class="n">windows</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">whitespace</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D2630#inline-10768" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">highlightwindow.h:58</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">void</span> \
<span style="color: #004012">highlightWindows</span><span class="p">(</span><span \
style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: \
#aa2211"><</span><span class="n">KWin</span><span style="color: \
#aa2211">::</span><span class="n">EffectWindow</span> <span style="color: \
#aa2211">*></span> <span style="color: #aa2211">&</span><span \
class="n">windows</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">EffectWindow* (no space)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2630" \
rel="noreferrer">https://phabricator.kde.org/D2630</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: \
</strong>sebas, luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic