[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2680: [Task Manager] Activate tasks by Meta + number shortcuts
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-09-06 14:13:35
Message-ID: 20160906141326.68709.28075.D6ADBF5B () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> CMakeLists.txt:35
> +                      KF5::WindowSystem
> +                      KF5::XmlGui)
> 

Do we really need KActionCollection? At least in KWin I ported away from it, because \
I don't want the xmlgui dependency. Overall KActionCollection is just doing some \
convenience stuff which is not really needed.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">graesslin added inline comments.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2680" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D2680#inline-10515" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:35</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;">                      KF5::WindowSystem<span \
class="bright">)</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">                      KF5::WindowSystem </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">                      KF5::XmlGui) \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Do we really need KActionCollection? At least in KWin I ported away \
from it, because I don&#039;t want the xmlgui dependency. Overall KActionCollection \
is just doing some convenience stuff which is not really \
needed.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2680" \
rel="noreferrer">https://phabricator.kde.org/D2680</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design, hein<br /><strong>Cc: \
</strong>graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]