[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 23 lines] D2636: Remove non visible internal windows from the x stacking or
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-08-31 14:13:52
Message-ID: differential-rev-PHID-DREV-n6j4k47d2lq3pprzeegj-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  KWin always has a few internal windows around which are not visible.
  A QWindow created somewhere, but not shown. Such windows should not
  be part of the stacking order.
  
  If they are it breaks code which looks at the top most window in the
  stacking order like e.g. SlidebackEffect.
  
  This change ensures that the stacking order gets updated whenever a
  ShellClient gets hidden and that internal windows with isShown being
  false are excluded from the stacking order.
  
  BUG: 364483

REPOSITORY
  rKWIN KWin

BRANCH
  stacking-order-only-visible-internal-windows

REVISION DETAIL
  https://phabricator.kde.org/D2636

AFFECTED FILES
  autotests/integration/internal_window.cpp
  layers.cpp
  workspace.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma on Wayland.<br />Restricted Application added subscribers: \
kwin, plasma-devel.<br />Restricted Application added projects: Plasma on Wayland, \
KWin.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2636" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>KWin \
always has a few internal windows around which are not visible.<br /> A QWindow \
created somewhere, but not shown. Such windows should not<br /> be part of the \
stacking order.</p>

<p>If they are it breaks code which looks at the top most window in the<br />
stacking order like e.g. SlidebackEffect.</p>

<p>This change ensures that the stacking order gets updated whenever a<br />
ShellClient gets hidden and that internal windows with isShown being<br />
false are excluded from the stacking order.</p>

<p>BUG: 364483</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>stacking-order-only-visible-internal-windows</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2636" \
rel="noreferrer">https://phabricator.kde.org/D2636</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/internal_window.cpp<br /> layers.cpp<br \
/> workspace.cpp</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: \
</strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]