From kde-panel-devel  Wed Aug 31 14:13:52 2016
From: =?utf-8?q?graesslin_=28Martin_Gr=C3=A4=C3=9Flin=29?= <noreply () phabricator ! kde ! or
Date: Wed, 31 Aug 2016 14:13:52 +0000
To: kde-panel-devel
Subject: [Differential] [Request, 23 lines] D2636: Remove non visible internal windows from the x stacking or
Message-Id: <differential-rev-PHID-DREV-n6j4k47d2lq3pprzeegj-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147265286109474
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--d6b14624f6a744729713679bb46e9b2b"

--d6b14624f6a744729713679bb46e9b2b
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  KWin always has a few internal windows around which are not visible.
  A QWindow created somewhere, but not shown. Such windows should not
  be part of the stacking order.
  
  If they are it breaks code which looks at the top most window in the
  stacking order like e.g. SlidebackEffect.
  
  This change ensures that the stacking order gets updated whenever a
  ShellClient gets hidden and that internal windows with isShown being
  false are excluded from the stacking order.
  
  BUG: 364483

REPOSITORY
  rKWIN KWin

BRANCH
  stacking-order-only-visible-internal-windows

REVISION DETAIL
  https://phabricator.kde.org/D2636

AFFECTED FILES
  autotests/integration/internal_window.cpp
  layers.cpp
  workspace.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

--d6b14624f6a744729713679bb46e9b2b
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">graesslin=20created=20this=20revision.<br=20/>g=
raesslin=20added=20reviewers:=20KWin,=20Plasma=20on=20Wayland.<br=20/>Restr=
icted=20Application=20added=20subscribers:=20kwin,=20plasma-devel.<br=20/>R=
estricted=20Application=20added=20projects:=20Plasma=20on=20Wayland,=20KWin=
.</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20marg=
in:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=
=20bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20backgroun=
d-image:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-b=
lock;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phab=
ricator.kde.org/D2636"=20rel=3D"noreferrer">View=20Revision</a></tr></table=
><br=20/><div><strong>REVISION=20SUMMARY</strong><div><p>KWin=20always=20ha=
s=20a=20few=20internal=20windows=20around=20which=20are=20not=20visible.<br=
=20/>
A=20QWindow=20created=20somewhere,=20but=20not=20shown.=20Such=20windows=20=
should=20not<br=20/>
be=20part=20of=20the=20stacking=20order.</p>

<p>If=20they=20are=20it=20breaks=20code=20which=20looks=20at=20the=20top=20=
most=20window=20in=20the<br=20/>
stacking=20order=20like=20e.g.=20SlidebackEffect.</p>

<p>This=20change=20ensures=20that=20the=20stacking=20order=20gets=20updated=
=20whenever=20a<br=20/>
ShellClient=20gets=20hidden=20and=20that=20internal=20windows=20with=20isSh=
own=20being<br=20/>
false=20are=20excluded=20from=20the=20stacking=20order.</p>

<p>BUG:=20364483</p></div></div><br=20/><div><strong>REPOSITORY</strong><di=
v><div>rKWIN=20KWin</div></div></div><br=20/><div><strong>BRANCH</strong><d=
iv><div>stacking-order-only-visible-internal-windows</div></div></div><br=
=20/><div><strong>REVISION=20DETAIL</strong><div><a=20href=3D"https://phabr=
icator.kde.org/D2636"=20rel=3D"noreferrer">https://phabricator.kde.org/D263=
6</a></div></div><br=20/><div><strong>AFFECTED=20FILES</strong><div><div>au=
totests/integration/internal_window.cpp<br=20/>
layers.cpp<br=20/>
workspace.cpp</div></div></div><br=20/><div><strong>EMAIL=20PREFERENCES</st=
rong><div><a=20href=3D"https://phabricator.kde.org/settings/panel/emailpref=
erences/"=20rel=3D"noreferrer">https://phabricator.kde.org/settings/panel/e=
mailpreferences/</a></div></div><br=20/><div><strong>To:=20</strong>graessl=
in,=20KWin,=20Plasma=20on=20Wayland<br=20/><strong>Cc:=20</strong>plasma-de=
vel,=20kwin,=20lesliezhai,=20ali-mohamed,=20hardening,=20jensreuterberg,=20=
abetts,=20sebas<br=20/></div>
--d6b14624f6a744729713679bb46e9b2b--