[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2630: Support highlighting windows through EffectsHandlerImpl
From:       luebking_(Thomas_Lübking) <noreply () phabricator ! kde ! org>
Date:       2016-08-31 13:10:07
Message-ID: 20160831131002.14401.43628.274F9253 () phabricator ! kde ! org
[Download RAW message or body]

luebking added inline comments.

INLINE COMMENTS

> kwineffects.h:496
> +     **/
> +    virtual bool performFeature(Feature feature, const QVariantList &arguments);
> +

maybe only "perform" (and have the signature fill in the information), but in general \
a much better solution ;-)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">luebking added inline comments.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2630" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D2630#inline-10351" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwineffects.h:496</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"><span style="color: #74777d">     **/</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span \
class="n">virtual</span> <span style="color: #aa4000">bool</span> <span style="color: \
#004012">performFeature</span><span class="p">(</span><span class="n">Feature</span> \
<span class="n">feature</span><span class="p">,</span> <span style="color: \
#aa4000">const</span> <span class="n">QVariantList</span> <span style="color: \
#aa2211">&amp;</span><span class="n">arguments</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">maybe only &quot;perform&quot; (and have the signature fill in the \
information), but in general a much better solution \
;-)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2630" \
rel="noreferrer">https://phabricator.kde.org/D2630</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: \
</strong>luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]