From kde-panel-devel  Wed Aug 31 13:10:07 2016
From: =?utf-8?q?luebking_=28Thomas_L=C3=BCbking=29?= <noreply () phabricator ! kde ! org>
Date: Wed, 31 Aug 2016 13:10:07 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D2630: Support highlighting windows through EffectsHandlerImpl
Message-Id: <20160831131002.14401.43628.274F9253 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147264902608088
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--4592bea9e6b743b7b61819eb77637386"

--4592bea9e6b743b7b61819eb77637386
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

luebking added inline comments.

INLINE COMMENTS

> kwineffects.h:496
> +     **/
> +    virtual bool performFeature(Feature feature, const QVariantList &arguments);
> +

maybe only "perform" (and have the signature fill in the information), but in general a much better solution ;-)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

--4592bea9e6b743b7b61819eb77637386
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">luebking=20added=20inline=20comments.</td><a=20=
style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margin:=200=208=
px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20bold;=20bo=
rder-radius:=203px;=20background-color:=20#F7F7F9;=20background-image:=20li=
near-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-block;=20borde=
r:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabricator.kde.o=
rg/D2630"=20rel=3D"noreferrer">View=20Revision</a></tr></table><br=20/><div=
><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=206px=200=
=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20border-rad=
ius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F7;=20borde=
r-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=200=201px=
=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20background:=20#ef=
f2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=3D"float:=
=20right;=20text-decoration:=20none;"=20href=3D"https://phabricator.kde.org=
/D2630#inline-10351"=20rel=3D"noreferrer">View=20Inline</a><span=20style=3D=
"color:=20#4b4d51;=20font-weight:=20bold;">kwineffects.h:496</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;"><span=20style=3D"col=
or:=20#74777d">=20=20=20=20=20**/</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"n">virtual</span>=20<span=20styl=
e=3D"color:=20#aa4000">bool</span>=20<span=20style=3D"color:=20#004012">per=
formFeature</span><span=20class=3D"p">(</span><span=20class=3D"n">Feature</=
span>=20<span=20class=3D"n">feature</span><span=20class=3D"p">,</span>=20<s=
pan=20style=3D"color:=20#aa4000">const</span>=20<span=20class=3D"n">QVarian=
tList</span>=20<span=20style=3D"color:=20#aa2211">&amp;</span><span=20class=
=3D"n">arguments</span><span=20class=3D"p">);</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">maybe=20only=20&quot;perform&quot;=20(and=20h=
ave=20the=20signature=20fill=20in=20the=20information),=20but=20in=20genera=
l=20a=20much=20better=20solution=20;-)</p></div></div></div></div></div><br=
=20/><div><strong>REPOSITORY</strong><div><div>rKWIN=20KWin</div></div></di=
v><br=20/><div><strong>REVISION=20DETAIL</strong><div><a=20href=3D"https://=
phabricator.kde.org/D2630"=20rel=3D"noreferrer">https://phabricator.kde.org=
/D2630</a></div></div><br=20/><div><strong>EMAIL=20PREFERENCES</strong><div=
><a=20href=3D"https://phabricator.kde.org/settings/panel/emailpreferences/"=
=20rel=3D"noreferrer">https://phabricator.kde.org/settings/panel/emailprefe=
rences/</a></div></div><br=20/><div><strong>To:=20</strong>graesslin,=20KWi=
n,=20Plasma=20on=20Wayland<br=20/><strong>Cc:=20</strong>luebking,=20plasma=
-devel,=20kwin,=20lesliezhai,=20ali-mohamed,=20hardening,=20jensreuterberg,=
=20abetts,=20sebas<br=20/></div>
--4592bea9e6b743b7b61819eb77637386--