[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
From: Painless Roaster <painless.roaster () gmail ! com>
Date: 2016-08-31 9:18:55
Message-ID: 20160831091855.7578.62188 () mimi ! kde ! org
[Download RAW message or body]
--===============2695102219285989006==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote:
> > Ship It!
>
> Eike Hein wrote:
> Do you need someone to commit this for you?
>
> Painless Roaster wrote:
> I do not have an account on github.
>
> Eike Hein wrote:
> Thanks, I'll see about getting this in next week.
>
> Eike Hein wrote:
> Can you give me a real name I can use on the commit?
Radek Bucek
radek.bucek@voipmonitor.org
thank you for commit
- Painless
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97884
-----------------------------------------------------------
On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> -----------------------------------------------------------
>
> (Updated Čec. 13, 2016, 1:13 odp.)
>
>
> Review request for Plasma.
>
>
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
> - enable multiline edit
> - fix size and position
> - fix escape from edit if user pressed Esc
> - fix suppress open file (or folder) if user clicked in editbox
> - fix size and position in popup mode
>
>
> Diffs
> -----
>
> containments/desktop/package/contents/ui/FolderView.qml ced3507
>
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Painless Roaster
>
>
--===============2695102219285989006==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128423/">https://git.reviewboard.kde.org/r/128423/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On červenec 28th, 2016, 6:02 dop. UTC, \
<b>Painless Roaster</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">Ship It!</pre> </blockquote>
<p>On srpen 23rd, 2016, 6:35 odp. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do \
you need someone to commit this for you?</p></pre> </blockquote>
<p>On srpen 26th, 2016, 10:58 dop. UTC, <b>Painless Roaster</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do \
not have an account on github.</p></pre> </blockquote>
<p>On srpen 28th, 2016, 9:11 dop. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks, I'll see about getting this in next week.</p></pre> </blockquote>
<p>On srpen 30th, 2016, 7:37 odp. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can \
you give me a real name I can use on the commit?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Radek \
Bucek radek.bucek@voipmonitor.org</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">thank you for commit</p></pre> <br />
<p>- Painless</p>
<br />
<p>On červenec 13th, 2016, 1:13 odp. UTC, Painless Roaster wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Painless Roaster.</div>
<p style="color: grey;"><i>Updated Čec. 13, 2016, 1:13 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097">https://bugs.kde.org/show_bug.cgi?id=361097</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">fix rename file (or folder) in folder plugin (and \
desktop in folder mode)
- enable multiline edit
- fix size and position
- fix escape from edit if user pressed Esc
- fix suppress open file (or folder) if user clicked in editbox
- fix size and position in popup mode</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/desktop/package/contents/ui/FolderView.qml <span style="color: \
grey">(ced3507)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128423/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2695102219285989006==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic