[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128802: task bar lines
From: Andreas Kainz <kainz.a () gmail ! com>
Date: 2016-08-31 8:00:07
Message-ID: 20160831080007.21343.48563 () mimi ! kde ! org
[Download RAW message or body]
--===============3955724939554890933==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 30, 2016, 10:57 nachm., Eike Hein wrote:
> > Tech-wise I have no objections, the SVG looks clean.
> >
> > Design-wise I'm conflicted. Unlike the old implementation of the lines, this time \
> > no attempt was made to vert-center the content in the remaining negative space. \
> > This avoids old problems, but on the other hand of course means you get \
> > unbalanced margins; the lines eat into the button. With fully-filled icons that \
> > don't have padding, that means the line can be very close to the icon. Hmm. But I \
> > trust the VDG did the math on the pro/con here.
>
> Eike Hein wrote:
> Actually, while I won't withdraw the Ship it!, I have to say the more I use it, the \
> more I dislike the unbalanced margins. It feels like the icon and text are hanging \
> from the top line like a sign from a ceiling, with a lot of empty space below it. \
> If the text label is additionally a short one, it feels like someone took the \
> content and dragged it up-left. It just feels unharmonious and unfinished somehow. \
> I like the appearance otherwise (I always liked the line idea, and I like the \
> filled backgorunds in the new version), but I worry this is another case of us \
> going with something that somehow feels half-done.
> Andreas, to what degree is this design shaped by the restrictions of the theming \
> system? If you had complete control, would this look different somehow?
andreas k:
Dear plasma and vdg, please test the tasks.svgz file as much as possible cause \
improvements are always welcome and i will ship it only when i get a ship it from \
plasma and vdg. I will work on the improvements as long as needed. When i get the two \
ship it before saterday it will released with 5.26 and with plasma 5.8. If the ship \
it get later no problem.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98803
-----------------------------------------------------------
On Aug. 30, 2016, 3:54 nachm., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128802/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2016, 3:54 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Update of the tasks.svgz file
>
> focus task
> ----------
> had now a 3px height line in Highlight color (direction of the line is the same \
> than the lines in kicker, system tray, ...
> normal task
> -----------
> no line no color at all no indicator. breeze mean no additional unusefull \
> information and space for the elements to breath
> hover task
> ----------
> blue Highlight color line like focus task with additional Highlight color \
> background and 24% opacity
> attention task
> --------------
> had a 3px height line in NeutralText color (old one didn't use colorscheme here)
>
> minimzed task
> -------------
> rectangular element with Text color and 0.16% opacity (you can see it now in breeze \
> and breeze-dark color scheme)
> I know it's to late for kf5.26 (03.09) but however if you think it should be \
> available with plasma 5.8 LTS let me know.
>
> Diffs
> -----
>
> src/desktoptheme/breeze/widgets/tasks.svgz 15a5921
>
> Diff: https://git.reviewboard.kde.org/r/128802/diff/
>
>
> Testing
> -------
>
> the stylesheed stuff were checked with different color schemes and with kate in the \
> svg "source code".
>
> File Attachments
> ----------------
>
> the tasks.svgz file for your tests please copy it to your plasma theme dictionary
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/fe0f0fc4-2952-4711-8965-bfdca0eeaee1__tasks.svgz
> preview of the different tasks (inkscape file preview)
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/223b09e7-44a5-4431-bb7c-ad64a78a39e3__preview.png
> Breeze Preview
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/8c0dc0f2-88b5-4da8-84c5-d9acbb04c10e__Breeze.png
> Breeze Dark Color Scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/6ab1fb1b-47bc-4a1b-a9ba-991d4371070c__Breeze-Dark.png
> Arch Color Scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/c09eddcb-7026-400d-8246-3ed4f24a6e45__Arch.png
> Oxygen Color Scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/4cfe2879-9234-4625-abcc-188942628e81__Oxygen.png
> Honeycomb color scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/5ed41231-fddd-4b30-9087-f1e702ade7ac__Honeycomb.png
> update tasks file with suggestions from kai
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/5ba391cd-6bbc-43df-ab51-fcab9cbf964c__tasks.svgz
> Breeze Color Scheme with updated tasks.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/202f150a-1011-4ca9-acfc-1811af24ae79__Screenshot_20160830_155736.png
> Breeze Dark Color Scheme with updated tasks.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/88a6cb0d-571d-43e9-9901-8e55ac238073__Screenshot_20160830_155802.png
> Honeycomb Color Scheme with updated tasks.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/f3be8584-bfb3-42e4-b687-87309615a9dd__Screenshot_20160830_155820.png
> now with ButtonHover for hover task
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/c068c5ab-341f-4c31-a94b-a737befa058b__tasks.svgz
>
>
> Thanks,
>
> Andreas Kainz
>
>
--===============3955724939554890933==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128802/">https://git.reviewboard.kde.org/r/128802/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 30th, 2016, 10:57 nachm. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tech-wise I have no objections, the SVG looks \
clean.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Design-wise I'm conflicted. Unlike the old \
implementation of the lines, this time no attempt was made to vert-center the content \
in the remaining negative space. This avoids old problems, but on the other hand of \
course means you get unbalanced margins; the lines eat into the button. With \
fully-filled icons that don't have padding, that means the line can be very close to \
the icon. Hmm. But I trust the VDG did the math on the pro/con here.</p></pre> \
</blockquote>
<p>On August 30th, 2016, 11:06 nachm. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Actually, while I won't withdraw the Ship it!, I have to say the more I use \
it, the more I dislike the unbalanced margins. It feels like the icon and text are \
hanging from the top line like a sign from a ceiling, with a lot of empty space below \
it. If the text label is additionally a short one, it feels like someone took the \
content and dragged it up-left. It just feels unharmonious and unfinished somehow. I \
like the appearance otherwise (I always liked the line idea, and I like the filled \
backgorunds in the new version), but I worry this is another case of us going with \
something that somehow feels half-done.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Andreas, to what degree \
is this design shaped by the restrictions of the theming system? If you had complete \
control, would this look different somehow?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">andreas k: Dear plasma and vdg, please test the tasks.svgz file as much as \
possible cause improvements are always welcome and i will ship it only when i get a \
ship it from plasma and vdg. I will work on the improvements as long as needed. When \
i get the two ship it before saterday it will released with 5.26 and with plasma 5.8. \
If the ship it get later no problem.</p></pre> <br />
<p>- Andreas</p>
<br />
<p>On August 30th, 2016, 3:54 nachm. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2016, 3:54 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Update of the tasks.svgz file</p> <h2 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">focus task</h2> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">had now a 3px height \
line in Highlight color (direction of the line is the same than the lines in kicker, \
system tray, ...</p> <h2 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">normal task</h2> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">no line no color at all no indicator. breeze mean no additional unusefull \
information and space for the elements to breath</p> <h2 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">hover task</h2> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">blue Highlight color line like focus \
task with additional Highlight color background and 24% opacity</p> <h2 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">attention task</h2> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">had a 3px height line \
in NeutralText color (old one didn't use colorscheme here)</p> <h2 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">minimzed task</h2> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">rectangular element with Text color and \
0.16% opacity (you can see it now in breeze and breeze-dark color scheme)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I know it's to late for kf5.26 (03.09) but however if you think it should \
be available with plasma 5.8 LTS let me know.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the stylesheed stuff were checked with different color \
schemes and with kate in the svg "source code".</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/breeze/widgets/tasks.svgz <span style="color: \
grey">(15a5921)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128802/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/fe0f0fc4-2952-4711-8965-bfdca0eeaee1__tasks.svgz">the \
tasks.svgz file for your tests please copy it to your plasma theme \
dictionary</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/223b09e7-44a5-4431-bb7c-ad64a78a39e3__preview.png">preview \
of the different tasks (inkscape file preview)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/8c0dc0f2-88b5-4da8-84c5-d9acbb04c10e__Breeze.png">Breeze \
Preview</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/6ab1fb1b-47bc-4a1b-a9ba-991d4371070c__Breeze-Dark.png">Breeze \
Dark Color Scheme</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/c09eddcb-7026-400d-8246-3ed4f24a6e45__Arch.png">Arch \
Color Scheme</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/4cfe2879-9234-4625-abcc-188942628e81__Oxygen.png">Oxygen \
Color Scheme</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/5ed41231-fddd-4b30-9087-f1e702ade7ac__Honeycomb.png">Honeycomb \
color scheme</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/5ba391cd-6bbc-43df-ab51-fcab9cbf964c__tasks.svgz">update \
tasks file with suggestions from kai</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/202f150a-1011-4ca9-acfc-1811af24ae79__Screenshot_20160830_155736.png">Breeze \
Color Scheme with updated tasks.svgz file</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/88a6cb0d-571d-43e9-9901-8e55ac238073__Screenshot_20160830_155802.png">Breeze \
Dark Color Scheme with updated tasks.svgz file</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/f3be8584-bfb3-42e4-b687-87309615a9dd__Screenshot_20160830_155820.png">Honeycomb \
Color Scheme with updated tasks.svgz file</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/c068c5ab-341f-4c31-a94b-a737befa058b__tasks.svgz">now \
with ButtonHover for hover task</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3955724939554890933==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic