[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 6 lines] D2633: Make plasma_install_package work with KDE_INSTALL_DIRS_NO_D
From:       "kossebau (Friedrich W. H. Kossebau)" <noreply () phabricator ! kde ! org>
Date:       2016-08-30 23:43:36
Message-ID: differential-rev-PHID-DREV-xwtbvw4mitwbajjqbnec-req () phabricator ! kde ! org
[Download RAW message or body]

kossebau created this revision.
kossebau added reviewers: Plasma, mart, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Currently plasma_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED
  is set to TRUE, because the macro is still using the deprecated vars
  DATA_INSTALL_DIR & SERVICES_INSTALL_DIR.
  It should be fine to bump the min version of ECM required to needed ECM 1.6.0,
  as someone using KF5 5.26 very surely also has a similar recent ECM.

BRANCH
  letMacroUseKDEINSTALLDIR

REVISION DETAIL
  https://phabricator.kde.org/D2633

AFFECTED FILES
  KF5PlasmaMacros.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #plasma, mart, sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">kossebau created this revision.<br />kossebau added \
reviewers: Plasma, mart, sebas.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2633" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Currently plasma_install_package fails if \
KDE_INSTALL_DIRS_NO_DEPRECATED<br /> is set to TRUE, because the macro is still using \
the deprecated vars<br /> DATA_INSTALL_DIR &amp; SERVICES_INSTALL_DIR.<br />
It should be fine to bump the min version of ECM required to needed ECM 1.6.0,<br />
as someone using KF5 5.26 very surely also has a similar recent \
ECM.</p></div></div><br \
/><div><strong>BRANCH</strong><div><div>letMacroUseKDEINSTALLDIR</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2633" \
rel="noreferrer">https://phabricator.kde.org/D2633</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>KF5PlasmaMacros.cmake</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>kossebau, Plasma, mart, sebas<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]