From kde-panel-devel  Tue Aug 30 23:43:36 2016
From: "kossebau (Friedrich W. H. Kossebau)" <noreply () phabricator ! kde ! org>
Date: Tue, 30 Aug 2016 23:43:36 +0000
To: kde-panel-devel
Subject: [Differential] [Request, 6 lines] D2633: Make plasma_install_package work with KDE_INSTALL_DIRS_NO_D
Message-Id: <differential-rev-PHID-DREV-xwtbvw4mitwbajjqbnec-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147260063428782
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--c86bff255d924176abb015766d049560"

--c86bff255d924176abb015766d049560
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

kossebau created this revision.
kossebau added reviewers: Plasma, mart, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Currently plasma_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED
  is set to TRUE, because the macro is still using the deprecated vars
  DATA_INSTALL_DIR & SERVICES_INSTALL_DIR.
  It should be fine to bump the min version of ECM required to needed ECM 1.6.0,
  as someone using KF5 5.26 very surely also has a similar recent ECM.

BRANCH
  letMacroUseKDEINSTALLDIR

REVISION DETAIL
  https://phabricator.kde.org/D2633

AFFECTED FILES
  KF5PlasmaMacros.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #plasma, mart, sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--c86bff255d924176abb015766d049560
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">kossebau=20created=20this=20revision.<br=20/>ko=
ssebau=20added=20reviewers:=20Plasma,=20mart,=20sebas.<br=20/>Restricted=20=
Application=20added=20a=20project:=20Plasma.<br=20/>Restricted=20Applicatio=
n=20added=20a=20subscriber:=20plasma-devel.</td><a=20style=3D"text-decorati=
on:=20none;=20padding:=204px=208px;=20margin:=200=208px=208px;=20float:=20r=
ight;=20color:=20#464C5C;=20font-weight:=20bold;=20border-radius:=203px;=20=
background-color:=20#F7F7F9;=20background-image:=20linear-gradient(to=20bot=
tom,#fff,#f1f0f1);=20display:=20inline-block;=20border:=201px=20solid=20rgb=
a(71,87,120,.2);"=20href=3D"https://phabricator.kde.org/D2633"=20rel=3D"nor=
eferrer">View=20Revision</a></tr></table><br=20/><div><strong>REVISION=20SU=
MMARY</strong><div><p>Currently=20plasma_install_package=20fails=20if=20KDE=
_INSTALL_DIRS_NO_DEPRECATED<br=20/>
is=20set=20to=20TRUE,=20because=20the=20macro=20is=20still=20using=20the=20=
deprecated=20vars<br=20/>
DATA_INSTALL_DIR=20&amp;=20SERVICES_INSTALL_DIR.<br=20/>
It=20should=20be=20fine=20to=20bump=20the=20min=20version=20of=20ECM=20requ=
ired=20to=20needed=20ECM=201.6.0,<br=20/>
as=20someone=20using=20KF5=205.26=20very=20surely=20also=20has=20a=20simila=
r=20recent=20ECM.</p></div></div><br=20/><div><strong>BRANCH</strong><div><=
div>letMacroUseKDEINSTALLDIR</div></div></div><br=20/><div><strong>REVISION=
=20DETAIL</strong><div><a=20href=3D"https://phabricator.kde.org/D2633"=20re=
l=3D"noreferrer">https://phabricator.kde.org/D2633</a></div></div><br=20/><=
div><strong>AFFECTED=20FILES</strong><div><div>KF5PlasmaMacros.cmake</div><=
/div></div><br=20/><div><strong>EMAIL=20PREFERENCES</strong><div><a=20href=
=3D"https://phabricator.kde.org/settings/panel/emailpreferences/"=20rel=3D"=
noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a=
></div></div><br=20/><div><strong>To:=20</strong>kossebau,=20Plasma,=20mart=
,=20sebas<br=20/><strong>Cc:=20</strong>plasma-devel,=20lesliezhai,=20ali-m=
ohamed,=20jensreuterberg,=20abetts,=20sebas<br=20/></div>
--c86bff255d924176abb015766d049560--