[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2610: Make icon follow styleHints
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-08-30 15:53:24
Message-ID: 20160830155322.129995.28684.E7C716E9 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson added a comment.


  In https://phabricator.kde.org/D2610#48964, @wbauer wrote:
  
  > In https://phabricator.kde.org/D2610#48934, @colomar wrote:
  >
  > > The only raison d'être for "double-click to open" is to be able to select on \
single click. If selecting is not possible (as is the case both in the panel and in a \
desktop containment), there is no reason for opening only on double-click (other than \
consistency with Windows, but an icon widget in a Desktop containment is not the same \
as an icon on the Windows desktop, because the Windows desktop behaves like our \
folderview containment, not like our desktop containment).  >
  >
  >
  
  
  Reverted.
  
  (wbauer, sorry hit push just before your comment, wasn't just ignoring your \
opinion)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2610

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: wbauer, colomar, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added a comment.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2610" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote \
style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2610#48964" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D2610#48964</a>, <a href="https://phabricator.kde.org/p/wbauer/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@wbauer</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2610#48934" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D2610#48934</a>, <a href="https://phabricator.kde.org/p/colomar/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@colomar</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>The only raison d&#039;être for \
&quot;double-click to open&quot; is to be able to select on single click. If \
selecting is not possible (as is the case both in the panel and in a desktop \
containment), there is no reason for opening only on double-click (other than \
consistency with Windows, but an icon widget in a Desktop containment is not the same \
as an icon on the Windows desktop, because the Windows desktop behaves like our \
folderview containment, not like our desktop containment).</p></div> </blockquote>

</div>
</blockquote>

<p>Reverted.</p>

<p>(wbauer, sorry hit push just before your comment, wasn&#039;t just ignoring your \
opinion)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2610" \
rel="noreferrer">https://phabricator.kde.org/D2610</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, mart<br /><strong>Cc: \
</strong>wbauer, colomar, broulik, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]