[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 11 lines] D2627: Set the restore geometry after placing a ShellClient for t
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-08-30 11:20:55
Message-ID: differential-rev-PHID-DREV-oatdmqdk2bf75h4hr6hn-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The restore geometry gets initially set to 0/0xsize before the placement
  is done. When going into updateClientArea and then afterwards into
  AbstractClient::checkWorkspacePosition the geometry restory is used for
  calculating the new position. This results in windows getting moved to
  0/0 when e.g. plugging in a new screen or a panel changes, etc.
  
  This change ensures that the restore geometry is set correctly after the
  first placement.
  
  BUG: 366696

REPOSITORY
  rKWIN KWin

BRANCH
  geometry-restore-after-placement

REVISION DETAIL
  https://phabricator.kde.org/D2627

AFFECTED FILES
  autotests/integration/plasma_surface_test.cpp
  shell_client.cpp
  shell_client.h
  workspace.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma on Wayland, bshah.<br />Restricted Application added \
subscribers: kwin, plasma-devel.<br />Restricted Application added projects: Plasma \
on Wayland, KWin.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2627" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
restore geometry gets initially set to 0/0xsize before the placement<br /> is done. \
When going into updateClientArea and then afterwards into<br /> \
AbstractClient::checkWorkspacePosition the geometry restory is used for<br /> \
calculating the new position. This results in windows getting moved to<br /> 0/0 when \
e.g. plugging in a new screen or a panel changes, etc.</p>

<p>This change ensures that the restore geometry is set correctly after the<br />
first placement.</p>

<p>BUG: 366696</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>geometry-restore-after-placement</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2627" \
rel="noreferrer">https://phabricator.kde.org/D2627</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/plasma_surface_test.cpp<br /> \
shell_client.cpp<br /> shell_client.h<br />
workspace.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland, bshah<br \
/><strong>Cc: </strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]