From kde-panel-devel  Tue Aug 30 11:20:55 2016
From: =?utf-8?q?graesslin_=28Martin_Gr=C3=A4=C3=9Flin=29?= <noreply () phabricator ! kde ! or
Date: Tue, 30 Aug 2016 11:20:55 +0000
To: kde-panel-devel
Subject: [Differential] [Request, 11 lines] D2627: Set the restore geometry after placing a ShellClient for t
Message-Id: <differential-rev-PHID-DREV-oatdmqdk2bf75h4hr6hn-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147255607314710
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--e27c4c1591ac4c03a8682f077cc3a261"

--e27c4c1591ac4c03a8682f077cc3a261
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The restore geometry gets initially set to 0/0xsize before the placement
  is done. When going into updateClientArea and then afterwards into
  AbstractClient::checkWorkspacePosition the geometry restory is used for
  calculating the new position. This results in windows getting moved to
  0/0 when e.g. plugging in a new screen or a panel changes, etc.
  
  This change ensures that the restore geometry is set correctly after the
  first placement.
  
  BUG: 366696

REPOSITORY
  rKWIN KWin

BRANCH
  geometry-restore-after-placement

REVISION DETAIL
  https://phabricator.kde.org/D2627

AFFECTED FILES
  autotests/integration/plasma_surface_test.cpp
  shell_client.cpp
  shell_client.h
  workspace.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

--e27c4c1591ac4c03a8682f077cc3a261
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">graesslin=20created=20this=20revision.<br=20/>g=
raesslin=20added=20reviewers:=20KWin,=20Plasma=20on=20Wayland,=20bshah.<br=
=20/>Restricted=20Application=20added=20subscribers:=20kwin,=20plasma-devel=
.<br=20/>Restricted=20Application=20added=20projects:=20Plasma=20on=20Wayla=
nd,=20KWin.</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208=
px;=20margin:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font=
-weight:=20bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20b=
ackground-image:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20=
inline-block;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"http=
s://phabricator.kde.org/D2627"=20rel=3D"noreferrer">View=20Revision</a></tr=
></table><br=20/><div><strong>REVISION=20SUMMARY</strong><div><p>The=20rest=
ore=20geometry=20gets=20initially=20set=20to=200/0xsize=20before=20the=20pl=
acement<br=20/>
is=20done.=20When=20going=20into=20updateClientArea=20and=20then=20afterwar=
ds=20into<br=20/>
AbstractClient::checkWorkspacePosition=20the=20geometry=20restory=20is=20us=
ed=20for<br=20/>
calculating=20the=20new=20position.=20This=20results=20in=20windows=20getti=
ng=20moved=20to<br=20/>
0/0=20when=20e.g.=20plugging=20in=20a=20new=20screen=20or=20a=20panel=20cha=
nges,=20etc.</p>

<p>This=20change=20ensures=20that=20the=20restore=20geometry=20is=20set=20c=
orrectly=20after=20the<br=20/>
first=20placement.</p>

<p>BUG:=20366696</p></div></div><br=20/><div><strong>REPOSITORY</strong><di=
v><div>rKWIN=20KWin</div></div></div><br=20/><div><strong>BRANCH</strong><d=
iv><div>geometry-restore-after-placement</div></div></div><br=20/><div><str=
ong>REVISION=20DETAIL</strong><div><a=20href=3D"https://phabricator.kde.org=
/D2627"=20rel=3D"noreferrer">https://phabricator.kde.org/D2627</a></div></d=
iv><br=20/><div><strong>AFFECTED=20FILES</strong><div><div>autotests/integr=
ation/plasma_surface_test.cpp<br=20/>
shell_client.cpp<br=20/>
shell_client.h<br=20/>
workspace.cpp</div></div></div><br=20/><div><strong>EMAIL=20PREFERENCES</st=
rong><div><a=20href=3D"https://phabricator.kde.org/settings/panel/emailpref=
erences/"=20rel=3D"noreferrer">https://phabricator.kde.org/settings/panel/e=
mailpreferences/</a></div></div><br=20/><div><strong>To:=20</strong>graessl=
in,=20KWin,=20Plasma=20on=20Wayland,=20bshah<br=20/><strong>Cc:=20</strong>=
plasma-devel,=20kwin,=20lesliezhai,=20ali-mohamed,=20hardening,=20jensreute=
rberg,=20abetts,=20sebas<br=20/></div>
--e27c4c1591ac4c03a8682f077cc3a261--