'Re: Review Request 128314: Fix for bug 364530'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128314: Fix for bug 364530
From:       Chinmoy Ranjan Pradhan <chinmoyrp65 () gmail ! com>
Date:       2016-07-31 15:28:46
Message-ID: 20160731152846.20873.54059 () mimi ! kde ! org
[Download RAW message or body]

--===============3366120232351739723==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128314/
-----------------------------------------------------------

(Updated July 31, 2016, 3:28 p.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Bugs: 364530
    https://bugs.kde.org/show_bug.cgi?id=364530

Repository: kio

Description
-------

The function KFileItem::targetUrl() expands "desktop:/" to "/home/$USER/Desktop/" and \
doesn't add scheme "file" to the url. Due to this a schemeless url is passed to KRun \
causing KRun to show an error message despite the fact that the file exist.

The proposed patch will cause targetUrl() to check the url for a scheme and add \
"file" scheme if there exist no scheme.

Diffs
-----

  src/core/kfileitem.cpp b5ed5fd 

Diff: https://git.reviewboard.kde.org/r/128314/diff/

Testing
-------

File Attachments
----------------

kio_desktop.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/33d2380d-586f-4085-89d5-62fb794b8f4c__kio_desktop.patch

Thanks,

Chinmoy Ranjan Pradhan

--===============3366120232351739723==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128314/">https://git.reviewboard.kde.org/r/128314/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Chinmoy Ranjan Pradhan.</div>

<p style="color: grey;"><i>Updated July 31, 2016, 3:28 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=364530">364530</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The function KFileItem::targetUrl() expands \
"desktop:/" to "/home/$USER/Desktop/" and doesn't add scheme "file" to the url. Due \
to this a schemeless url is passed to KRun causing KRun to show an error message \
despite the fact that the file exist.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The proposed patch will \
cause targetUrl() to check the url for a scheme and add "file" scheme if there exist \
no scheme.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kfileitem.cpp <span style="color: grey">(b5ed5fd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128314/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/33d2380d-586f-4085-89d5-62fb794b8f4c__kio_desktop.patch">kio_desktop.patch</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3366120232351739723==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 