From kde-panel-devel Sun Jul 31 15:28:46 2016 From: Chinmoy Ranjan Pradhan Date: Sun, 31 Jul 2016 15:28:46 +0000 To: kde-panel-devel Subject: Re: Review Request 128314: Fix for bug 364530 Message-Id: <20160731152846.20873.54059 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146997894526037 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7716824938797962789==" --===============7716824938797962789== Content-Type: multipart/alternative; boundary="===============3366120232351739723==" --===============3366120232351739723== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128314/ ----------------------------------------------------------- (Updated July 31, 2016, 3:28 p.m.) Status ------ This change has been discarded. Review request for Plasma. Bugs: 364530 https://bugs.kde.org/show_bug.cgi?id=364530 Repository: kio Description ------- The function KFileItem::targetUrl() expands "desktop:/" to "/home/$USER/Desktop/" and doesn't add scheme "file" to the url. Due to this a schemeless url is passed to KRun causing KRun to show an error message despite the fact that the file exist. The proposed patch will cause targetUrl() to check the url for a scheme and add "file" scheme if there exist no scheme. Diffs ----- src/core/kfileitem.cpp b5ed5fd Diff: https://git.reviewboard.kde.org/r/128314/diff/ Testing ------- File Attachments ---------------- kio_desktop.patch https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/33d2380d-586f-4085-89d5-62fb794b8f4c__kio_desktop.patch Thanks, Chinmoy Ranjan Pradhan --===============3366120232351739723== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128314/

This change has been discarded.

Review request for Plasma.

By Chinmoy Ranjan Pradhan.

Updated July 31, 2016, 3:28 p.m.

Bugs: 364530

Repository: kio

Description

The function KFileItem::targetUrl() expands "desktop:/" to "/home/$USER/Desktop/" and doesn't add scheme "file" to the url. Due to this a schemeless url is passed to KRun causing KRun to show an error message despite the fact that the file exist.
The proposed patch will cause targetUrl() to check the url for a scheme and add "file" scheme if there exist no scheme.

Diffs

src/core/kfileitem.cpp (b5ed5fd)

View Diff

File Attachments

kio_desktop.patch

--===============3366120232351739723==-- --===============7716824938797962789== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7716824938797962789==--