[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 3 lines] D2054: Fix for bug 364530
From:       "chinmoyr (Chinmoy Ranjan Pradhan)" <noreply () phabricator ! kde ! org>
Date:       2016-06-30 15:59:04
Message-ID: differential-rev-PHID-DREV-6btwpp3kuaup3hkwmfpg-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


chinmoyr created this revision.
chinmoyr added reviewers: sebas, bshah, Plasma.
chinmoyr added a subscriber: Plasma.
chinmoyr set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
chinmoyr added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In plasma-workspace the prepareUDSEntry in file kioslave/desktop/kio_desktop.cpp sets \
UDS_TARGET_URL as   '//entry.insert(KIO::UDSEntry::UDS_TARGET_URL, \
entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)//'.  Now using UDS_LOCAL_PATH will return the \
path without file scheme. This schemeless path will be set in UDS_TARGET_URL and then will be \
used by  kio's //targetUrl //and then final passed to //Krun// where it will fail the scheme \
test eventually leading to the said bug.  
  What this patch will do is simply create a url using //QUrl::fromLocalFile// and then pass \
the //url.toString()//'s result  to //insert//. This way the bug won't occur.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2054

AFFECTED FILES
  new:kioslave/desktop/kio_desktop.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, sebas, bshah, #plasma
Cc: plasma-devel, #plasma, jensreuterberg, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">chinmoyr created this revision.<br />chinmoyr added reviewers: sebas, \
bshah, Plasma.<br />chinmoyr added a subscriber: Plasma.<br />chinmoyr set the repository for \
this revision to rPLASMAWORKSPACE Plasma Workspace.<br />chinmoyr added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2054" rel="noreferrer">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>In plasma-workspace the prepareUDSEntry in file \
kioslave/desktop/kio_desktop.cpp sets UDS_TARGET_URL as <br /> \
&#039;<em>entry.insert(KIO::UDSEntry::UDS_TARGET_URL, \
entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)</em>&#039;.<br /> Now using UDS_LOCAL_PATH \
will return the path without file scheme. This schemeless path will be set in UDS_TARGET_URL \
and then will be used by<br /> kio&#039;s <em>targetUrl </em>and then final passed to \
<em>Krun</em> where it will fail the scheme test eventually leading to the said bug.</p>

<p>What this patch will do is simply create a url using <em>QUrl::fromLocalFile</em> and then \
pass the <em>url.toString()</em>&#039;s result  to <em>insert</em>. This way the bug won&#039;t \
occur.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2054" \
rel="noreferrer">https://phabricator.kde.org/D2054</a></div></div><br /><div><strong>AFFECTED \
FILES</strong><div><div>new:kioslave/desktop/kio_desktop.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>chinmoyr, sebas, bshah, Plasma<br /><strong>Cc: \
</strong>plasma-devel, Plasma, jensreuterberg, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]