--===============1761542938596965674==
Content-Type: multipart/alternative; boundary="3ed7a9cf456c4427995422b273f00912"

--3ed7a9cf456c4427995422b273f00912
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

chinmoyr created this revision.
chinmoyr added reviewers: sebas, bshah, Plasma.
chinmoyr added a subscriber: Plasma.
chinmoyr set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
chinmoyr added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In plasma-workspace the prepareUDSEntry in file kioslave/desktop/kio_desktop.cpp sets UDS_TARGET_URL as 
  '//entry.insert(KIO::UDSEntry::UDS_TARGET_URL, entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)//'.
  Now using UDS_LOCAL_PATH will return the path without file scheme. This schemeless path will be set in UDS_TARGET_URL and then will be used by
  kio's //targetUrl //and then final passed to //Krun// where it will fail the scheme test eventually leading to the said bug.
  
  What this patch will do is simply create a url using //QUrl::fromLocalFile// and then pass the //url.toString()//'s result  to //insert//. This way the bug won't occur.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2054

AFFECTED FILES
  new:kioslave/desktop/kio_desktop.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, sebas, bshah, #plasma
Cc: plasma-devel, #plasma, jensreuterberg, sebas

--3ed7a9cf456c4427995422b273f00912
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">chinmoyr=20created=20this=20revision.<br=20/>ch=
inmoyr=20added=20reviewers:=20sebas,=20bshah,=20Plasma.<br=20/>chinmoyr=20a=
dded=20a=20subscriber:=20Plasma.<br=20/>chinmoyr=20set=20the=20repository=
=20for=20this=20revision=20to=20rPLASMAWORKSPACE=20Plasma=20Workspace.<br=
=20/>chinmoyr=20added=20a=20project:=20Plasma.<br=20/>Restricted=20Applicat=
ion=20added=20a=20subscriber:=20plasma-devel.</td><a=20style=3D"text-decora=
tion:=20none;=20padding:=204px=208px;=20margin:=200=208px=208px;=20float:=
=20right;=20color:=20#464C5C;=20font-weight:=20bold;=20border-radius:=203px=
;=20background-color:=20#F7F7F9;=20background-image:=20linear-gradient(to=
=20bottom,#fff,#f1f0f1);=20display:=20inline-block;=20border:=201px=20solid=
=20rgba(71,87,120,.2);"=20href=3D"https://phabricator.kde.org/D2054"=20rel=
=3D"noreferrer">View=20Revision</a></tr></table><br=20/><div><strong>REVISI=
ON=20SUMMARY</strong><div><p>In=20plasma-workspace=20the=20prepareUDSEntry=
=20in=20file=20kioslave/desktop/kio_desktop.cpp=20sets=20UDS_TARGET_URL=20a=
s=20<br=20/>
&#039;<em>entry.insert(KIO::UDSEntry::UDS_TARGET_URL,=20entry.stringValue(K=
IO::UDSEntry::UDS_LOCAL_PATH)</em>&#039;.<br=20/>
Now=20using=20UDS_LOCAL_PATH=20will=20return=20the=20path=20without=20file=
=20scheme.=20This=20schemeless=20path=20will=20be=20set=20in=20UDS_TARGET_U=
RL=20and=20then=20will=20be=20used=20by<br=20/>
kio&#039;s=20<em>targetUrl=20</em>and=20then=20final=20passed=20to=20<em>Kr=
un</em>=20where=20it=20will=20fail=20the=20scheme=20test=20eventually=20lea=
ding=20to=20the=20said=20bug.</p>

<p>What=20this=20patch=20will=20do=20is=20simply=20create=20a=20url=20using=
=20<em>QUrl::fromLocalFile</em>=20and=20then=20pass=20the=20<em>url.toStrin=
g()</em>&#039;s=20result=20=20to=20<em>insert</em>.=20This=20way=20the=20bu=
g=20won&#039;t=20occur.</p></div></div><br=20/><div><strong>REPOSITORY</str=
ong><div><div>rPLASMAWORKSPACE=20Plasma=20Workspace</div></div></div><br=20=
/><div><strong>REVISION=20DETAIL</strong><div><a=20href=3D"https://phabrica=
tor.kde.org/D2054"=20rel=3D"noreferrer">https://phabricator.kde.org/D2054</=
a></div></div><br=20/><div><strong>AFFECTED=20FILES</strong><div><div>new:k=
ioslave/desktop/kio_desktop.cpp</div></div></div><br=20/><div><strong>EMAIL=
=20PREFERENCES</strong><div><a=20href=3D"https://phabricator.kde.org/settin=
gs/panel/emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kde.or=
g/settings/panel/emailpreferences/</a></div></div><br=20/><div><strong>To:=
=20</strong>chinmoyr,=20sebas,=20bshah,=20Plasma<br=20/><strong>Cc:=20</str=
ong>plasma-devel,=20Plasma,=20jensreuterberg,=20sebas<br=20/></div>
--3ed7a9cf456c4427995422b273f00912--

--===============1761542938596965674==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============1761542938596965674==--