'Re: Review Request 128097: optional mode to draw checked menu items with only a check mark'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128097: optional mode to draw checked menu items with only a check mark
From:       Yichao Yu <yyc1992 () gmail ! com>
Date:       2016-06-04 21:51:56
Message-ID: 20160604215156.29452.71508 () mimi ! kde ! org
[Download RAW message or body]

--===============1578884550129332118==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On 六月 4, 2016, 4:02 p.m., Yichao Yu wrote:
> > LGTM, this should be added to the configure UI. The tab for popup menu should \
> > work. The .ui file needs to be updated to include the checkbox for this and a \
> > corresponding rule should be added to the .cpp file (There should already be a \
> > number of boolean options in that tab that you can copy.)
> 
> René J.V. Bertin wrote:
> I can have another look, thinking it should be easy to figure out where and how the \
> "Menu items" UI options were set up, but got lost. I see that I should have opened \
> the qtcurveconfigbase.ui file in a text editor. That at least clears up where the \
> controls are defined, but there's still a lot of things going on in the code that \
> undoubtedly made it easy for the original author but not to someone jumping in for \
> a casual change!

Just to be clear, I've had a look at that file (possibly with small tweaks) but I'm \
not the original author either.... The UI file should be fairly standard and either \
kdevelop or qtcreator/qtdesigner should be able to edit it (text editor should work \
too).

This is also why I suggested copying a nearby option. `grep`ing the widget id worked \
pretty well last time I did something simlar.

- Yichao

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128097/#review96189
-----------------------------------------------------------

On 六月 4, 2016, 3:53 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128097/
> -----------------------------------------------------------
> 
> (Updated 六月 4, 2016, 3:53 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, Plasma and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> This introduces an option (hidden for now) to adorn checked menu items with only a \
> check mark rather than the same widget that is used for checkboxes or radio buttons \
> (for sets of mutually exclusive menu items). 
> Initially I implemented this by simply skipping the widget "box" and drawing only \
> the checkbox tick for both kinds of menu items (cf. \
> https://bugs.kde.org/show_bug.cgi?id=363895). I then realised that this looks weird \
> when the user uses a very tall or tiny font (or has a high DPI screen). Therefore \
> the check is now generated using the UniCode `Check Mark` glyph (? cf. \
> http://www.fileformat.info/info/unicode/char/2713/index.htm) rendered in the menu \
> font (or `Apple Symbols`, on OS X). 
> A new member is introduced in the `Options` structure that controls this new \
> behaviour. Its value is read from and written to the config file, but I have not \
> yet implemented its UI control through the configuration interface. I'll want some \
> guidance for that step. 
> I propose to make this the default behaviour on OS X, so that popup menus can be \
> closer in appearance to the native menus from the toplevel menubar (those menus are \
> not rendered through Qt, and use a single check mark too). 
> The GTk2 style already rendered checked menu items like this so I did not change \
> anything there (and don't really plan to touch that code at all). 
> 
> Diffs
> -----
> 
> gtk2/common/common.h cb0ec87 
> gtk2/common/config_file.cpp 96936e2 
> qt4/common/common.h 313db33 
> qt4/common/config_file.cpp c58ad1a 
> qt4/style/qtcurve.cpp 951ec1a 
> qt5/common/common.h bb103fd 
> qt5/common/config_file.cpp 362381a 
> qt5/style/qtcurve_api.cpp b8535da 
> qt5/style/qtcurve_primitive.cpp a8a2bed 
> 
> Diff: https://git.reviewboard.kde.org/r/128097/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9 and Linux with Qt 4.8.7 and Qt 5.6.0 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
> 

--===============1578884550129332118==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128097/">https://git.reviewboard.kde.org/r/128097/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On 六月 4th, 2016, 4:02 p.m. EDT, <b>Yichao \
Yu</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">LGTM, this should be added to the configure UI. The \
tab for popup menu should work. The .ui file needs to be updated to include the \
checkbox for this and a corresponding rule should be added to the .cpp file (There \
should already be a number of boolean options in that tab that you can \
copy.)</p></pre>  </blockquote>

 <p>On 六月 4th, 2016, 4:24 p.m. EDT, <b>René J.V. Bertin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can \
have another look, thinking it should be easy to figure out where and how the "Menu \
items" UI options were set up, but got lost. I see that I should have opened the \
qtcurveconfigbase.ui file in a text editor. That at least clears up where the \
controls are defined, but there's still a lot of things going on in the code that \
undoubtedly made it easy for the original author but not to someone jumping in for a \
casual change!</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
to be clear, I've had a look at that file (possibly with small tweaks) but I'm not \
the original author either.... The UI file should be fairly standard and either \
kdevelop or qtcreator/qtdesigner should be able to edit it (text editor should work \
too).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is also why I suggested copying a nearby option. \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">grep</code>ing the widget id worked pretty \
well last time I did something simlar.</p></pre> <br />

<p>- Yichao</p>

<br />
<p>On 六月 4th, 2016, 3:53 p.m. EDT, René J.V. Bertin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X, Plasma and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated 六月 4, 2016, 3:53 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This introduces an option (hidden for now) to adorn \
checked menu items with only a check mark rather than the same widget that is used \
for checkboxes or radio buttons (for sets of mutually exclusive menu items).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Initially I implemented this by simply skipping the widget "box" and \
drawing only the checkbox tick for both kinds of menu items (cf. \
https://bugs.kde.org/show_bug.cgi?id=363895). I then realised that this looks weird \
when the user uses a very tall or tiny font (or has a high DPI screen). Therefore the \
check is now generated using the UniCode <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Check \
Mark</code> glyph (? cf. http://www.fileformat.info/info/unicode/char/2713/index.htm) \
rendered in the menu font (or <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Apple \
Symbols</code>, on OS X).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">A new member is introduced in the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Options</code> structure that controls this new behaviour. \
Its value is read from and written to the config file, but I have not yet implemented \
its UI control through the configuration interface. I'll want some guidance for that \
step.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I propose to make this the default behaviour on OS X, \
so that popup menus can be closer in appearance to the native menus from the toplevel \
menubar (those menus are not rendered through Qt, and use a single check mark \
too).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The GTk2 style already rendered checked menu items \
like this so I did not change anything there (and don't really plan to touch that \
code at all).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9 and Linux with Qt 4.8.7 and Qt 5.6.0 \
.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>gtk2/common/common.h <span style="color: grey">(cb0ec87)</span></li>

 <li>gtk2/common/config_file.cpp <span style="color: grey">(96936e2)</span></li>

 <li>qt4/common/common.h <span style="color: grey">(313db33)</span></li>

 <li>qt4/common/config_file.cpp <span style="color: grey">(c58ad1a)</span></li>

 <li>qt4/style/qtcurve.cpp <span style="color: grey">(951ec1a)</span></li>

 <li>qt5/common/common.h <span style="color: grey">(bb103fd)</span></li>

 <li>qt5/common/config_file.cpp <span style="color: grey">(362381a)</span></li>

 <li>qt5/style/qtcurve_api.cpp <span style="color: grey">(b8535da)</span></li>

 <li>qt5/style/qtcurve_primitive.cpp <span style="color: grey">(a8a2bed)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128097/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1578884550129332118==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 