[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-05-31 19:36:53
Message-ID: 20160531193632.7528.13307.899B4E1A () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Ah, ok, I misunderstood that this will inherit by session since I thought kwin start the \
> script exit-with-session. 
> But then I still have one minor concern, for any window that actually inside kwin (e.g. right \
> click on title bar -> window specific settings), the input method will be forced to \
> qtvirtualkeyboard. Though I know input method is not commonly being used there, but I don't \
> think that's expected behavior for input method user.

That dialog is a separate binary kwin_rules_dialog. Except for the virtual keyboard and wayland \
debug console I don't think there are any user-facing kwin-internal windows (that are real \
windows, not counting stuff like close buttons on present windows and so on)

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel


[Attachment #5 (text/html)]

<div>broulik added inline comments.</div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: \
6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1638#inline-6697" rel="noreferrer">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">xuetianweng</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">main_wayland.cpp:449</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Ah, ok, I misunderstood \
that this will inherit by session since I thought kwin start the script exit-with-session.</p>

<p style="padding: 0; margin: 8px;">But then I still have one minor concern, for any window \
that actually inside kwin (e.g. right click on title bar -&gt; window specific settings), the \
input method will be forced to qtvirtualkeyboard. Though I know input method is not commonly \
being used there, but I don&#039;t think that&#039;s expected behavior for input method \
user.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">That dialog is a separate binary kwin_rules_dialog. Except for the virtual \
keyboard and wayland debug console I don&#039;t think there are any user-facing kwin-internal \
windows (that are real windows, not counting stuff like close buttons on present windows and so \
on)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>virtual-keyboard</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1638" \
rel="noreferrer">https://phabricator.kde.org/D1638</a></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, Plasma, sebas<br /><strong>Cc: </strong>xuetianweng, \
sebas, mart, broulik, plasma-devel<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]