From kde-panel-devel Tue May 31 19:36:53 2016 From: "broulik (Kai Uwe Broulik)" Date: Tue, 31 May 2016 19:36:53 +0000 To: kde-panel-devel Subject: [Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland Message-Id: <20160531193632.7528.13307.899B4E1A () phabricator ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146472342613932 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1752353267014284002==" --===============1752353267014284002== Content-Type: multipart/alternative; boundary="4be88d35c738410fa8b8f2de303475d1" --4be88d35c738410fa8b8f2de303475d1 Content-Type: text/plain; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit broulik added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Ah, ok, I misunderstood that this will inherit by session since I thought kwin start the script exit-with-session. > > But then I still have one minor concern, for any window that actually inside kwin (e.g. right click on title bar -> window specific settings), the input method will be forced to qtvirtualkeyboard. Though I know input method is not commonly being used there, but I don't think that's expected behavior for input method user. That dialog is a separate binary kwin_rules_dialog. Except for the virtual keyboard and wayland debug console I don't think there are any user-facing kwin-internal windows (that are real windows, not counting stuff like close buttons on present windows and so on) REPOSITORY rKWIN KWin BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: xuetianweng, sebas, mart, broulik, plasma-devel --4be88d35c738410fa8b8f2de303475d1 Content-Type: text/html; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable
broulik=20added=20inline=20comments.
INLINE= =20COMMENTS
View=20Inlinexuetianweng=20wrote=20in=20main_wayland.cpp:449
Ah,=20ok,=20I=20misunders= tood=20that=20this=20will=20inherit=20by=20session=20since=20I=20thought=20= kwin=20start=20the=20script=20exit-with-session.

But=20then=20I=20still=20have= =20one=20minor=20concern,=20for=20any=20window=20that=20actually=20inside= =20kwin=20(e.g.=20right=20click=20on=20title=20bar=20->=20window=20speci= fic=20settings),=20the=20input=20method=20will=20be=20forced=20to=20qtvirtu= alkeyboard.=20Though=20I=20know=20input=20method=20is=20not=20commonly=20be= ing=20used=20there,=20but=20I=20don't=20think=20that's=20expected= =20behavior=20for=20input=20method=20user.

That=20dialog=20is=20a=20separate=20binary=20= kwin_rules_dialog.=20Except=20for=20the=20virtual=20keyboard=20and=20waylan= d=20debug=20console=20I=20don't=20think=20there=20are=20any=20user-fac= ing=20kwin-internal=20windows=20(that=20are=20real=20windows,=20not=20count= ing=20stuff=20like=20close=20buttons=20on=20present=20windows=20and=20so=20= on)

REPOSITORY
rKWIN=20KWin
BRANCH
virtual-keyboard
REVISIO= N=20DETAIL
https://phabricator.kde.org/D1638
=
EMAIL=20PREFERENCES
https://= phabricator.kde.org/settings/panel/emailpreferences/
To:=20graesslin,=20Plasma,=20sebasCc= :=20xuetianweng,=20sebas,=20mart,=20broulik,=20plasma-devel
--4be88d35c738410fa8b8f2de303475d1-- --===============1752353267014284002== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1752353267014284002==--