[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D1722: Import next-gen libtaskmanager.
From: "hein (Eike Hein)" <noreply () phabricator ! kde ! org>
Date: 2016-05-31 10:48:49
Message-ID: 20160531104848.103227.76955.38ED4F1A () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in abstracttasksmodel.cpp:41-42
> traditionally these are called "display" and "decoration"
> lowercase and without the word "Role"
>
> Also you should be able to do
>
> roles = QAbstractItemModel::roles() to get them.
This was kept from the old lib, changing.
> broulik wrote in abstracttasksmodel.h:63
> I don't fully get that, can you clarify whether this means:
>
> - A task that "can be grouped" (judging from the enum value name)
> - A task that "is currently grouped" (judging from the comment)
It means what the comment says: If it's true, the task is not subject to grouping. \
That means it will never be grouped. It's used by the applet's Don't allow/Allow This \
Program To Be Grouped action.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1722
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, Plasma
Cc: broulik, davidedmundson, plasma-devel, sebas
[Attachment #5 (text/html)]
<div>hein added inline comments.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1722#inline-6598" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">abstracttasksmodel.cpp:41-42</span></div> <div style="margin: 8px 0; padding: \
0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">traditionally these are \
called "display" and "decoration" <br /> lowercase and without \
the word "Role"</p>
<p style="padding: 0; margin: 8px;">Also you should be able to do</p>
<p style="padding: 0; margin: 8px;">roles = QAbstractItemModel::roles() to get \
them.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">This was kept from the old lib, changing.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1722#inline-6612" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">abstracttasksmodel.h:63</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">I don't fully get that, can you clarify whether this means:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">A task that "can be grouped" (judging from \
the enum value name)</li> <li class="remarkup-list-item">A task that "is \
currently grouped" (judging from the comment)</li> </ul></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It \
means what the comment says: If it's true, the task is not subject to grouping. \
That means it will never be grouped. It's used by the applet's Don't \
allow/Allow This Program To Be Grouped action.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1722" \
rel="noreferrer">https://phabricator.kde.org/D1722</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>broulik, \
davidedmundson, plasma-devel, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic