[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D1722: Import next-gen libtaskmanager.
From:       "hein (Eike Hein)" <noreply () phabricator ! kde ! org>
Date:       2016-05-31 9:58:15
Message-ID: 20160531095814.6233.63745.BB7F5DC4 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in activityinfo.cpp:69
> If I have 4 activities. 2 running, 2 not.
> 
> numberOfActivities returns 2
> 
> I set one to running:
> 
> the property changes
> this signal is not emitted.

Good catch. I think the old lib had this issue too ...

KActivities has no convenient API to listen to changes in the list of running \
activities, it seems - instead you have to keep a KActivities::Info around for all \
activtities, and listen to their stateChanged signals. Annoying ...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas


[Attachment #5 (text/html)]

<div>hein added inline comments.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1722#inline-6599" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">activityinfo.cpp:69</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">If I have 4 activities. 2 \
running, 2 not.</p>

<p style="padding: 0; margin: 8px;">numberOfActivities returns 2</p>

<p style="padding: 0; margin: 8px;">I set one to running:</p>

<p style="padding: 0; margin: 8px;">the property changes<br />
this signal is not emitted.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Good \
catch. I think the old lib had this issue too ...</p>

<p style="padding: 0; margin: 8px;">KActivities has no convenient API to listen to \
changes in the list of running activities, it seems - instead you have to keep a \
KActivities::Info around for all activtities, and listen to their stateChanged \
signals. Annoying ...</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1722" \
rel="noreferrer">https://phabricator.kde.org/D1722</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]