'Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem
From:       Marco Martin <notmart () gmail ! com>
Date:       2016-05-31 9:26:56
Message-ID: 20160531092656.29452.6020 () mimi ! kde ! org
[Download RAW message or body]

--===============9215423188896069986==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127975/
-----------------------------------------------------------

(Updated May 31, 2016, 2:26 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit f3c05034d9e2ad3de984e833680b4b3def078430 by Marco Martin to \
branch master.

Repository: plasma-framework

Description
-------

Like KIconloader, support a Selected state, in IconItem, as in all generic \
svgs/framesvg it replaces the text color with HighlightedText and the background \
color with HighlightColor

Diffs
-----

  src/declarativeimports/core/framesvgitem.h 335a9b4 
  src/declarativeimports/core/framesvgitem.cpp 1bde3d2 
  src/declarativeimports/core/iconitem.h 38a9c7a 
  src/declarativeimports/core/iconitem.cpp 12008f8 
  src/plasma/private/svg_p.h 6f1efc2 
  src/plasma/private/theme_p.h 945fcef 
  src/plasma/private/theme_p.cpp 99e865b 
  src/plasma/svg.h 3a4ca1d 
  src/plasma/svg.cpp 507ed75 
  src/plasma/theme.cpp 3b7b371 
  tests/selected_svg.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127975/diff/

Testing
-------

File Attachments
----------------

showing a framesvg, a SvgItem and an IconItem
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/27777434-baf4-45d2-9f26-71b4b857502d__dadel4.png

Thanks,

Marco Martin

--===============9215423188896069986==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127975/">https://git.reviewboard.kde.org/r/127975/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated May 31, 2016, 2:26 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit f3c05034d9e2ad3de984e833680b4b3def078430 by Marco \
Martin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Like KIconloader, support a Selected state, in \
IconItem, as in all generic svgs/framesvg it replaces the text color with \
HighlightedText and the background color with HighlightColor</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/framesvgitem.h <span style="color: \
grey">(335a9b4)</span></li>

 <li>src/declarativeimports/core/framesvgitem.cpp <span style="color: \
grey">(1bde3d2)</span></li>

 <li>src/declarativeimports/core/iconitem.h <span style="color: \
grey">(38a9c7a)</span></li>

 <li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(12008f8)</span></li>

 <li>src/plasma/private/svg_p.h <span style="color: grey">(6f1efc2)</span></li>

 <li>src/plasma/private/theme_p.h <span style="color: grey">(945fcef)</span></li>

 <li>src/plasma/private/theme_p.cpp <span style="color: grey">(99e865b)</span></li>

 <li>src/plasma/svg.h <span style="color: grey">(3a4ca1d)</span></li>

 <li>src/plasma/svg.cpp <span style="color: grey">(507ed75)</span></li>

 <li>src/plasma/theme.cpp <span style="color: grey">(3b7b371)</span></li>

 <li>tests/selected_svg.qml <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127975/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/27777434-baf4-45d2-9f26-71b4b857502d__dadel4.png">showing \
a framesvg, a SvgItem and an IconItem</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9215423188896069986==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 