From kde-panel-devel Tue May 31 09:26:56 2016 From: Marco Martin Date: Tue, 31 May 2016 09:26:56 +0000 To: kde-panel-devel Subject: Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem Message-Id: <20160531092656.29452.6020 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146468683401087 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4068900052796251414==" --===============4068900052796251414== Content-Type: multipart/alternative; boundary="===============9215423188896069986==" --===============9215423188896069986== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/ ----------------------------------------------------------- (Updated May 31, 2016, 2:26 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit f3c05034d9e2ad3de984e833680b4b3def078430 by Marco Martin to branch master. Repository: plasma-framework Description ------- Like KIconloader, support a Selected state, in IconItem, as in all generic svgs/framesvg it replaces the text color with HighlightedText and the background color with HighlightColor Diffs ----- src/declarativeimports/core/framesvgitem.h 335a9b4 src/declarativeimports/core/framesvgitem.cpp 1bde3d2 src/declarativeimports/core/iconitem.h 38a9c7a src/declarativeimports/core/iconitem.cpp 12008f8 src/plasma/private/svg_p.h 6f1efc2 src/plasma/private/theme_p.h 945fcef src/plasma/private/theme_p.cpp 99e865b src/plasma/svg.h 3a4ca1d src/plasma/svg.cpp 507ed75 src/plasma/theme.cpp 3b7b371 tests/selected_svg.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127975/diff/ Testing ------- File Attachments ---------------- showing a framesvg, a SvgItem and an IconItem https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/27777434-baf4-45d2-9f26-71b4b857502d__dadel4.png Thanks, Marco Martin --===============9215423188896069986== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/

This change has been marked as submitted.

Review request for Plasma.
By Marco Martin.

Updated May 31, 2016, 2:26 a.m.

Changes

Submitted with commit f3c05034d9e2ad3de984e833680b4b3def078430 by Marco Martin to branch master.
Repository: plasma-framework

Description 

Like KIconloader, support a Selected state, in IconItem, as in all generic svgs/framesvg
it replaces the text color with HighlightedText and the background color with HighlightColor

Diffs

  • src/declarativeimports/core/framesvgitem.h (335a9b4)
  • src/declarativeimports/core/framesvgitem.cpp (1bde3d2)
  • src/declarativeimports/core/iconitem.h (38a9c7a)
  • src/declarativeimports/core/iconitem.cpp (12008f8)
  • src/plasma/private/svg_p.h (6f1efc2)
  • src/plasma/private/theme_p.h (945fcef)
  • src/plasma/private/theme_p.cpp (99e865b)
  • src/plasma/svg.h (3a4ca1d)
  • src/plasma/svg.cpp (507ed75)
  • src/plasma/theme.cpp (3b7b371)
  • tests/selected_svg.qml (PRE-CREATION)

View Diff

File Attachments

  • showing a framesvg, a SvgItem and an IconItem
    		•
    --===============9215423188896069986==-- --===============4068900052796251414== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4068900052796251414==--