[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Requested Changes To] D1718: [PanelView] Check whether we're X11 before calling QX11
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-05-30 14:39:05
Message-ID: 20160530143903.10309.69155.00D87753 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> panelview.cpp:593
>  #if HAVE_X11
> -    xcb_connection_t *c = QX11Info::connection();
> -    if (!c) {
> +    if (!QX11Info::isPlatformX11()) {
>          return;

I suggest to move the complete X11 block into the if. So that we can in future add an
else if (isWayland())

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1718

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, Plasma
Cc: plasma-devel, sebas

[Attachment #5 (text/html)]

<div>graesslin requested changes to this revision.<br />
graesslin added inline comments.<br />
This revision now requires changes to proceed.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1718#inline-6583" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">panelview.cpp:593</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span \
style="color: #304a96">#if HAVE_X11</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #ffd0d0;">    <span class="bright"></span><span style="color: \
#aa4000"><span class="bright">xcb_connection_t</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">*</span></span><span \
class="bright"></span><span class="n"><span class="bright">c</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">=</span></span><span class="bright"> </span><span \
class="n">QX11Info</span><span style="color: #aa2211">::<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">connection</span></span><span class="bright"></span><span \
class="p"><span class="bright">();</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;">    <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #aa2211">!</span><span class="n">c</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;">    <span class="bright"></span><span style="color: \
#aa4000"><span class="bright">if</span></span><span class="bright"> </span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">!</span></span><span \
class="n">QX11Info</span><span style="color: #aa2211">::<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">isPlatformX11</span></span><span class="bright"></span><span \
class="p"><span class="bright">())</span></span><span class="bright"> </span><span \
class="p"><span class="bright">{</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">        <span style="color: #aa4000">return</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
suggest to move the complete X11 block into the if. So that we can in future add \
an<br /> else if (isWayland())</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1718" \
rel="noreferrer">https://phabricator.kde.org/D1718</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, graesslin, Plasma<br /><strong>Cc: \
</strong>plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]