[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 5 lines] D1718: [PanelView] Check whether we're X11 before calling QX11Info
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-05-30 14:36:27
Message-ID: differential-rev-PHID-DREV-nbcejscolefdzzc2bapi-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik created this revision.
broulik added reviewers: Plasma, graesslin.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QX11Info::connection() looks up the connection in the QPA. The Wayland QPA happens \
to have a property with the same name, so it happily reinterpret_casts a \
wl_connection_t* to xcb_connection_t* and disaster ensues.

TEST PLAN
  Auto hiding panels still works on X11, haven't tested Wayland.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1718

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, graesslin
Cc: plasma-devel, sebas


[Attachment #5 (text/html)]

<div>broulik created this revision.<br />
broulik added reviewers: Plasma, graesslin.<br />
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.<br \
/> Restricted Application added a project: Plasma.<br />
Restricted Application added a subscriber: plasma-devel.</div><br \
/><div><strong>REVISION SUMMARY</strong><div><p>QX11Info::connection() looks up the \
connection in the QPA. The Wayland QPA happens to have a property with the same name, \
so it happily reinterpret_casts a wl_connection_t* to xcb_connection_t* and disaster \
ensues.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Auto hiding \
panels still works on X11, haven&#039;t tested Wayland.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1718" \
rel="noreferrer">https://phabricator.kde.org/D1718</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>shell/panelview.cpp</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, graesslin<br /><strong>Cc: \
</strong>plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]