[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127796: [SortFilterModel] Introduce limit and offset
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-04-30 19:12:48
Message-ID: 20160430191248.13920.86666 () mimi ! kde ! org
[Download RAW message or body]
--===============2089418568229445431==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On April 30, 2016, 7:10 nachm., David Edmundson wrote:
> > -1. Limiting+ sorting won't work properly.
> >
> > You're using source row to limit , but that's pre filter/sort.
Right.
So I'll make my own LimitingProxyModel then.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127796/#review95044
-----------------------------------------------------------
On April 30, 2016, 6:30 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127796/
> -----------------------------------------------------------
>
> (Updated April 30, 2016, 6:30 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This allows to limit the number of entries in the model and specify an offset, \
> useful for expandable lists and pagination. Comes with a unittest.
>
> Diffs
> -----
>
> autotests/sortfiltermodeltest.h e918fb0
> autotests/sortfiltermodeltest.cpp da0e393
> src/declarativeimports/core/corebindingsplugin.cpp e2b3a68
> src/declarativeimports/core/datamodel.h f43737c
> src/declarativeimports/core/datamodel.cpp 06b64e4
>
> Diff: https://git.reviewboard.kde.org/r/127796/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============2089418568229445431==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127796/">https://git.reviewboard.kde.org/r/127796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 30th, 2016, 7:10 nachm. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-1. Limiting+ sorting won't work properly.
You're using source row to limit , but that's pre filter/sort.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">So I'll make my own LimitingProxyModel \
then.</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On April 30th, 2016, 6:30 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated April 30, 2016, 6:30 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows to limit the number of entries in the \
model and specify an offset, useful for expandable lists and pagination. Comes with a \
unittest.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/sortfiltermodeltest.h <span style="color: grey">(e918fb0)</span></li>
<li>autotests/sortfiltermodeltest.cpp <span style="color: \
grey">(da0e393)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(e2b3a68)</span></li>
<li>src/declarativeimports/core/datamodel.h <span style="color: \
grey">(f43737c)</span></li>
<li>src/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(06b64e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127796/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2089418568229445431==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic