[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127796: [SortFilterModel] Introduce limit and offset
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-04-30 19:10:55
Message-ID: 20160430191055.11646.15192 () mimi ! kde ! org
[Download RAW message or body]

--===============8739365738841960469==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127796/#review95044
-----------------------------------------------------------



-1. Limiting+ sorting won't work properly.

You're using source row to limit , but that's pre filter/sort.

- David Edmundson


On April 30, 2016, 6:30 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127796/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 6:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows to limit the number of entries in the model and specify an offset, \
> useful for expandable lists and pagination. Comes with a unittest. 
> 
> Diffs
> -----
> 
> autotests/sortfiltermodeltest.h e918fb0 
> autotests/sortfiltermodeltest.cpp da0e393 
> src/declarativeimports/core/corebindingsplugin.cpp e2b3a68 
> src/declarativeimports/core/datamodel.h f43737c 
> src/declarativeimports/core/datamodel.cpp 06b64e4 
> 
> Diff: https://git.reviewboard.kde.org/r/127796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 


--===============8739365738841960469==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127796/">https://git.reviewboard.kde.org/r/127796/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-1. Limiting+ sorting \
won&#39;t work properly.

You&#39;re using source row to limit , but that&#39;s pre filter/sort.</pre>
 <br />









<p>- David Edmundson</p>


<br />
<p>On April 30th, 2016, 6:30 p.m. UTC, Kai Uwe Broulik wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated April 30, 2016, 6:30 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows to limit the number of entries in the \
model and specify an offset, useful for expandable lists and pagination. Comes with a \
unittest.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/sortfiltermodeltest.h <span style="color: grey">(e918fb0)</span></li>

 <li>autotests/sortfiltermodeltest.cpp <span style="color: \
grey">(da0e393)</span></li>

 <li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(e2b3a68)</span></li>

 <li>src/declarativeimports/core/datamodel.h <span style="color: \
grey">(f43737c)</span></li>

 <li>src/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(06b64e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127796/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============8739365738841960469==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic