[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 87 lines] D1514: [Milou] Optimize sources model
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-04-30 11:48:37
Message-ID: differential-rev-PHID-DREV-r5bujrygf7v52dlsmvns-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rMILOU Milou.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This optimizes the sources model by avoiding model resets and cleaning up the code.

TEST PLAN
  KRunner feels a lot snappier. It does not fix the initial lag we get when ListView \
creates all the delegates but subsequent updates to the results should be noticeably \
faster. Unfortunately KRunner jumps around a bit sometimes when results come and go \
which was previously probably covered by it just blocking without rendering that.  
  I didn't understand the way the results are stored in the model thorougly enough to \
make it a proper model with beginInsertRows/endInsertRows when new results are added, \
though.

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D1514

AFFECTED FILES
  lib/sourcesmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel, sebas


[Attachment #5 (text/html)]

<div>broulik created this revision.<br />
broulik added a reviewer: Plasma.<br />
broulik set the repository for this revision to rMILOU Milou.<br />
broulik added a project: Plasma.<br />
Restricted Application added a subscriber: plasma-devel.</div><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This optimizes the sources model by \
avoiding model resets and cleaning up the code.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>KRunner feels a lot snappier. It does not \
fix the initial lag we get when ListView creates all the delegates but subsequent \
updates to the results should be noticeably faster. Unfortunately KRunner jumps \
around a bit sometimes when results come and go which was previously probably covered \
by it just blocking without rendering that.</p>

<p>I didn&#039;t understand the way the results are stored in the model thorougly \
enough to make it a proper model with beginInsertRows/endInsertRows when new results \
are added, though.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rMILOU Milou</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1514" \
rel="noreferrer">https://phabricator.kde.org/D1514</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lib/sourcesmodel.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]