--===============6805830359117916565==
Content-Type: multipart/alternative; boundary="beca5d4fe28b4f079cbc5e62ef291fd9"

--beca5d4fe28b4f079cbc5e62ef291fd9
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rMILOU Milou.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This optimizes the sources model by avoiding model resets and cleaning up the code.

TEST PLAN
  KRunner feels a lot snappier. It does not fix the initial lag we get when ListView creates all the delegates but subsequent updates to the results should be noticeably faster. Unfortunately KRunner jumps around a bit sometimes when results come and go which was previously probably covered by it just blocking without rendering that.
  
  I didn't understand the way the results are stored in the model thorougly enough to make it a proper model with beginInsertRows/endInsertRows when new results are added, though.

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D1514

AFFECTED FILES
  lib/sourcesmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel, sebas

--beca5d4fe28b4f079cbc5e62ef291fd9
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<div>broulik=20created=20this=20revision.<br=20/>
broulik=20added=20a=20reviewer:=20Plasma.<br=20/>
broulik=20set=20the=20repository=20for=20this=20revision=20to=20rMILOU=20Mi=
lou.<br=20/>
broulik=20added=20a=20project:=20Plasma.<br=20/>
Restricted=20Application=20added=20a=20subscriber:=20plasma-devel.</div><br=
=20/><div><strong>REVISION=20SUMMARY</strong><div><p>This=20optimizes=20the=
=20sources=20model=20by=20avoiding=20model=20resets=20and=20cleaning=20up=
=20the=20code.</p></div></div><br=20/><div><strong>TEST=20PLAN</strong><div=
><p>KRunner=20feels=20a=20lot=20snappier.=20It=20does=20not=20fix=20the=20i=
nitial=20lag=20we=20get=20when=20ListView=20creates=20all=20the=20delegates=
=20but=20subsequent=20updates=20to=20the=20results=20should=20be=20noticeab=
ly=20faster.=20Unfortunately=20KRunner=20jumps=20around=20a=20bit=20sometim=
es=20when=20results=20come=20and=20go=20which=20was=20previously=20probably=
=20covered=20by=20it=20just=20blocking=20without=20rendering=20that.</p>

<p>I=20didn&#039;t=20understand=20the=20way=20the=20results=20are=20stored=
=20in=20the=20model=20thorougly=20enough=20to=20make=20it=20a=20proper=20mo=
del=20with=20beginInsertRows/endInsertRows=20when=20new=20results=20are=20a=
dded,=20though.</p></div></div><br=20/><div><strong>REPOSITORY</strong><div=
><div>rMILOU=20Milou</div></div></div><br=20/><div><strong>REVISION=20DETAI=
L</strong><div><a=20href=3D"https://phabricator.kde.org/D1514"=20rel=3D"nor=
eferrer">https://phabricator.kde.org/D1514</a></div></div><br=20/><div><str=
ong>AFFECTED=20FILES</strong><div><div>lib/sourcesmodel.cpp</div></div></di=
v><br=20/><div><strong>EMAIL=20PREFERENCES</strong><div><a=20href=3D"https:=
//phabricator.kde.org/settings/panel/emailpreferences/"=20rel=3D"noreferrer=
">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></d=
iv><br=20/><div><strong>To:=20</strong>broulik,=20Plasma<br=20/><strong>Cc:=
=20</strong>plasma-devel,=20sebas<br=20/></div>
--beca5d4fe28b4f079cbc5e62ef291fd9--

--===============6805830359117916565==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============6805830359117916565==--