[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127793: kuiserver: use QApplication rather than QCoreApplication
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-04-29 16:41:40
Message-ID: 20160429164140.8442.29695 () mimi ! kde ! org
[Download RAW message or body]
--===============2704457415515959507==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 29, 2016, 4:27 p.m., David Edmundson wrote:
> > Which part of ProgressListModel uses a UI?
>
> Rex Dieter wrote:
> Good question, I was largely just parot'ing comments from bug #348123 about this \
> proposed patch, I'll go digging.
> Rex Dieter wrote:
> Further detail from the bug in question in case it helps:
> The attached patch fixes the 'lingering kuiserver processes after logout' issue. In \
> debugging this I found that when using QCoreApplication, the kuiserver was not \
> being properly terminated and the associated dbus service never unregistered.
Seems KGuiServer is a full on KXmlGui app.
KUIServer is two things; the DBus tracker for jobs and whatnot - but also a fallback \
UI for if you don't have Plasma having "track file transfers and other jobs".
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127793/#review95026
-----------------------------------------------------------
On April 29, 2016, 4:34 p.m., Rex Dieter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127793/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 4:34 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 348123
> https://bugs.kde.org/show_bug.cgi?id=348123
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> As GUI elements are present in ProgressListModel, use QApplication
> rather than QCoreApplication to ensure a GUI eventloop.
>
>
> Diffs
> -----
>
> kuiserver/main.cpp 3cc118a
>
> Diff: https://git.reviewboard.kde.org/r/127793/diff/
>
>
> Testing
> -------
>
> plasmashell still functions normally, and kuiserver now properly exists at session \
> end.
>
> Thanks,
>
> Rex Dieter
>
>
--===============2704457415515959507==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127793/">https://git.reviewboard.kde.org/r/127793/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 29th, 2016, 4:27 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Which part of ProgressListModel uses a UI?</p></pre> \
</blockquote>
<p>On April 29th, 2016, 4:29 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good \
question, I was largely just parot'ing comments from bug #348123 about this proposed \
patch, I'll go digging.</p></pre> </blockquote>
<p>On April 29th, 2016, 4:33 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Further detail from the bug in question in case it helps:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> The attached patch fixes the 'lingering kuiserver processes after logout' \
issue. In debugging this I found that when using QCoreApplication, the kuiserver was \
not being properly terminated and the associated dbus service never \
unregistered.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems \
KGuiServer is a full on KXmlGui app.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">KUIServer is two \
things; the DBus tracker for jobs and whatnot - but also a fallback UI for if you \
don't have Plasma having "track file transfers and other jobs".</p></pre> <br />
<p>- David</p>
<br />
<p>On April 29th, 2016, 4:34 p.m. UTC, Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated April 29, 2016, 4:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348123">348123</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As GUI elements are present in ProgressListModel, use \
QApplication rather than QCoreApplication to ensure a GUI eventloop.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmashell still functions normally, and kuiserver \
now properly exists at session end.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kuiserver/main.cpp <span style="color: grey">(3cc118a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127793/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2704457415515959507==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic