--===============5324315472114243863== Content-Type: multipart/alternative; boundary="===============2704457415515959507==" --===============2704457415515959507== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 29, 2016, 4:27 p.m., David Edmundson wrote: > > Which part of ProgressListModel uses a UI? > > Rex Dieter wrote: > Good question, I was largely just parot'ing comments from bug #348123 about this proposed patch, I'll go digging. > > Rex Dieter wrote: > Further detail from the bug in question in case it helps: > The attached patch fixes the 'lingering kuiserver processes after logout' issue. In debugging this I found that when using QCoreApplication, the kuiserver was not being properly terminated and the associated dbus service never unregistered. Seems KGuiServer is a full on KXmlGui app. KUIServer is two things; the DBus tracker for jobs and whatnot - but also a fallback UI for if you don't have Plasma having "track file transfers and other jobs". - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127793/#review95026 ----------------------------------------------------------- On April 29, 2016, 4:34 p.m., Rex Dieter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127793/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 4:34 p.m.) > > > Review request for Plasma. > > > Bugs: 348123 > https://bugs.kde.org/show_bug.cgi?id=348123 > > > Repository: plasma-workspace > > > Description > ------- > > As GUI elements are present in ProgressListModel, use QApplication > rather than QCoreApplication to ensure a GUI eventloop. > > > Diffs > ----- > > kuiserver/main.cpp 3cc118a > > Diff: https://git.reviewboard.kde.org/r/127793/diff/ > > > Testing > ------- > > plasmashell still functions normally, and kuiserver now properly exists at session end. > > > Thanks, > > Rex Dieter > > --===============2704457415515959507== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127793/

On April 29th, 2016, 4:27 p.m. UTC, David Edmundson wrote:

Which part of ProgressListModel uses a UI?

On April 29th, 2016, 4:29 p.m. UTC, Rex Dieter wrote:

Good question, I was largely just parot'ing comments from bug #348123 about this proposed patch, I'll go digging.

On April 29th, 2016, 4:33 p.m. UTC, Rex Dieter wrote:

Further detail from the bug in question in case it helps:

The attached patch fixes the 'lingering kuiserver processes after logout' issue. In debugging this I found that when using QCoreApplication, the kuiserver was not being properly terminated and the associated dbus service never unregistered.
Seems KGuiServer is a full on KXmlGui app.


KUIServer is two things; the DBus tracker for jobs and whatnot - but also a fallback UI for if you don't have Plasma having "track file transfers and other jobs".

- David


On April 29th, 2016, 4:34 p.m. UTC, Rex Dieter wrote:

Review request for Plasma.
By Rex Dieter.

Updated April 29, 2016, 4:34 p.m.

Bugs: 348123
Repository: plasma-workspace

Description 

As GUI elements are present in ProgressListModel, use QApplication
rather than QCoreApplication to ensure a GUI eventloop.

Testing 

plasmashell still functions normally, and kuiserver now properly exists at session end.

Diffs

  • kuiserver/main.cpp (3cc118a)

View Diff
--===============2704457415515959507==-- --===============5324315472114243863== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5324315472114243863==--