[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2016-04-29 6:56:18
Message-ID: 20160429065618.8442.31118 () mimi ! kde ! org
[Download RAW message or body]
--===============4756098501638000508==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127780/#review95003
-----------------------------------------------------------
src/platformtheme/khintssettings.cpp (line 58)
<https://git.reviewboard.kde.org/r/127780/#comment64492>
Please pull, the code doesn't fit the current state in master.
- Martin Gräßlin
On April 28, 2016, 6:39 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127780/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 6:39 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-integration
>
>
> Description
> -------
>
> The app config (KSharedConfig::openConfig()) is a mix of the app's settings and \
> kdeglobals.
> Loading kdeglobals directly not only is a waste of resources, but breaks
> one of the key features of KConfig where a user can override global settings
> on a per app basis.
>
> What's worse is that KColorScheme when used directly does use the app config, so \
> some apps give an inconsistent mix of results if you try and override settings.
>
> Diffs
> -----
>
> src/platformtheme/kfontsettingsdata.cpp 94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360
> src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e
>
> Diff: https://git.reviewboard.kde.org/r/127780/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============4756098501638000508==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127780/">https://git.reviewboard.kde.org/r/127780/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127780/diff/1/?file=461492#file461492line58" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platformtheme/khintssettings.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">58</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">KHintsSettings</span><span class="o">::</span><span \
class="n">KHintsSettings</span><span class="p">()</span> <span class="o">:</span> \
<span class="n">QObject</span><span class="p">(</span><span class="mi">0</span><span \
class="p">)</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">58</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="n">KHintsSettings</span><span \
class="o">::</span><span class="n">KHintsSettings</span><span class="p">()</span> \
<span class="o">:</span> <span class="n">QObject</span><span class="p">(</span><span \
class="mi">0</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please pull, the code doesn't fit the current state in master.</p></pre> \
</div> </div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On April 28th, 2016, 6:39 p.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 28, 2016, 6:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-integration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The app config (KSharedConfig::openConfig()) is a mix \
of the app's settings and kdeglobals.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Loading kdeglobals \
directly not only is a waste of resources, but breaks one of the key features of \
KConfig where a user can override global settings on a per app basis. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What's worse is that KColorScheme when used directly \
does use the app config, so some apps give an inconsistent mix of results if you try \
and override settings.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/kfontsettingsdata.cpp <span style="color: \
grey">(94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360)</span></li>
<li>src/platformtheme/khintssettings.cpp <span style="color: \
grey">(5a40b91da691da3c0b599507098b655f4750a07e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127780/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4756098501638000508==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic