'Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-04-28 23:17:30
Message-ID: 20160428231730.8442.14040 () mimi ! kde ! org
[Download RAW message or body]

--===============1211014477407789669==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127780/#review94999
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On April 28, 2016, 6:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127780/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 6:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> -------
> 
> The app config (KSharedConfig::openConfig()) is a mix of the app's settings and \
> kdeglobals. 
> Loading kdeglobals directly not only is a waste of resources, but breaks
> one of the key features of KConfig where a user can override global settings
> on a per app basis. 
> 
> What's worse is that KColorScheme when used directly does use the app config, so \
> some apps give an inconsistent mix of results if you try and override settings. 
> 
> Diffs
> -----
> 
> src/platformtheme/kfontsettingsdata.cpp 94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360 
> src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e 
> 
> Diff: https://git.reviewboard.kde.org/r/127780/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============1211014477407789669==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127780/">https://git.reviewboard.kde.org/r/127780/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On April 28th, 2016, 6:39 p.m. CEST, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated April 28, 2016, 6:39 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-integration
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The app config (KSharedConfig::openConfig()) is a mix \
of the app's settings and kdeglobals.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Loading kdeglobals \
directly not only is a waste of resources, but breaks one of the key features of \
KConfig where a user can override global settings on a per app basis. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What's worse is that KColorScheme when used directly \
does use the app config, so some apps give an inconsistent mix of results if you try \
and override settings.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/platformtheme/kfontsettingsdata.cpp <span style="color: \
grey">(94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360)</span></li>

 <li>src/platformtheme/khintssettings.cpp <span style="color: \
grey">(5a40b91da691da3c0b599507098b655f4750a07e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127780/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1211014477407789669==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 