[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127781: Remove clearly broken code
From: Marco Martin <notmart () gmail ! com>
Date: 2016-04-28 19:33:15
Message-ID: 20160428193315.8442.22110 () mimi ! kde ! org
[Download RAW message or body]
--===============6587651923773122604==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127781/#review94990
-----------------------------------------------------------
that was done for distributions, but wasn't supposed to be any colors file installed \
by the default look and feel. perhaps is not the best way, the lnf could be \
restricted to just define a named theme as the default one in its defaults file.
- Marco Martin
On April 28, 2016, 4:48 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127781/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 4:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-integration
>
>
> Description
> -------
>
> This line never would have found anything and therefore clearly is not
> used and wasn't tested.
>
> Even assuming there wasn't a typo, it's a hardcoded path and we don't
> install anything there.
>
>
> Diffs
> -----
>
> src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e
>
> Diff: https://git.reviewboard.kde.org/r/127781/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============6587651923773122604==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127781/">https://git.reviewboard.kde.org/r/127781/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that \
was done for distributions, but wasn't supposed to be any colors file installed by \
the default look and feel. perhaps is not the best way, the lnf could be restricted \
to just define a named theme as the default one in its defaults file.</p></pre> <br \
/>
<p>- Marco Martin</p>
<br />
<p>On April 28th, 2016, 4:48 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 28, 2016, 4:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-integration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This line never would have found anything and therefore clearly is not \
used and wasn't tested.
Even assuming there wasn't a typo, it's a hardcoded path and we don't
install anything there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/khintssettings.cpp <span style="color: \
grey">(5a40b91da691da3c0b599507098b655f4750a07e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127781/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6587651923773122604==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic