--===============3892906190317774392== Content-Type: multipart/alternative; boundary="===============6587651923773122604==" --===============6587651923773122604== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127781/#review94990 ----------------------------------------------------------- that was done for distributions, but wasn't supposed to be any colors file installed by the default look and feel. perhaps is not the best way, the lnf could be restricted to just define a named theme as the default one in its defaults file. - Marco Martin On April 28, 2016, 4:48 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127781/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 4:48 p.m.) > > > Review request for Plasma. > > > Repository: plasma-integration > > > Description > ------- > > This line never would have found anything and therefore clearly is not > used and wasn't tested. > > Even assuming there wasn't a typo, it's a hardcoded path and we don't > install anything there. > > > Diffs > ----- > > src/platformtheme/khintssettings.cpp 5a40b91da691da3c0b599507098b655f4750a07e > > Diff: https://git.reviewboard.kde.org/r/127781/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > > --===============6587651923773122604== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127781/

that was done for distributions, but wasn't supposed to be any colors file installed by the default look and feel. perhaps is not the best way, the lnf could be restricted to just define a named theme as the default one in its defaults file.

- Marco Martin

On April 28th, 2016, 4:48 p.m. UTC, David Edmundson wrote:

Review request for Plasma.

By David Edmundson.

Updated April 28, 2016, 4:48 p.m.

Repository: plasma-integration

Description

This line never would have found anything and therefore clearly is not
used and wasn't tested.

Even assuming there wasn't a typo, it's a hardcoded path and we don't
install anything there.

Diffs

src/platformtheme/khintssettings.cpp (5a40b91da691da3c0b599507098b655f4750a07e)

View Diff

--===============6587651923773122604==-- --===============3892906190317774392== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3892906190317774392==--