[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127498: Cleanup warnings
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2016-03-31 13:47:14
Message-ID: 20160331134714.12706.10742 () mimi ! kde ! org
[Download RAW message or body]
--===============0931477057653577570==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127498/#review94153
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/card.cpp (line 47)
<https://git.reviewboard.kde.org/r/127498/#comment64076>
Perhaps we can just drop this conditional and make it require PA >= 5.0?
The reason is to reduce silent failures, #ifdefs sounds like a neat thing, but it \
quickly gets out of hand when people expect software to have the same features, and \
then it doesn't, but they don't see build failures.
My (current) Kubuntu has 6.0, my Debian Unstable has 8.0, I haven't investigated \
others, but it doesn't seem outrageous to require PA 5.0 for Plasma 5.7?
- Sebastian Kügler
On March 26, 2016, 9:07 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127498/
> -----------------------------------------------------------
>
> (Updated March 26, 2016, 9:07 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> Change some warnings to todo/fixme and fix the others.
>
>
> Diffs
> -----
>
> src/card.cpp 2e251a7
> src/context.cpp 115c8a7
> src/pulseaudio.cpp 1488784
>
> Diff: https://git.reviewboard.kde.org/r/127498/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Rosca
>
>
--===============0931477057653577570==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127498/">https://git.reviewboard.kde.org/r/127498/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127498/diff/3/?file=454300#file454300line47" \
style="color: black; font-weight: bold; text-decoration: underline;">src/card.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">47</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#warning more \
inconsistent api... profiles end with entry with name on null...</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#if PA_CHECK_VERSION(5, 0, 0)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Perhaps we can just drop this conditional and make it require PA >= \
5.0?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The reason is to reduce silent failures, #ifdefs \
sounds like a neat thing, but it quickly gets out of hand when people expect software \
to have the same features, and then it doesn't, but they don't see build \
failures.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">My (current) Kubuntu has 6.0, my Debian Unstable has \
8.0, I haven't investigated others, but it doesn't seem outrageous to require PA 5.0 \
for Plasma 5.7?</p></pre> </div>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On March 26th, 2016, 9:07 a.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 26, 2016, 9:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change some warnings to todo/fixme and fix the \
others.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/card.cpp <span style="color: grey">(2e251a7)</span></li>
<li>src/context.cpp <span style="color: grey">(115c8a7)</span></li>
<li>src/pulseaudio.cpp <span style="color: grey">(1488784)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127498/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0931477057653577570==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic