'Re: Review Request 127498: Cleanup warnings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127498: Cleanup warnings
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-03-26 9:07:31
Message-ID: 20160326090731.21226.4674 () mimi ! kde ! org
[Download RAW message or body]

--===============3560768227591757378==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127498/
-----------------------------------------------------------

(Updated March 26, 2016, 9:07 a.m.)

Review request for Plasma.

Changes
-------

Fix logic for volume changes - pa_cvolume_equal only compares pointers

Repository: plasma-pa

Description
-------

Change some warnings to todo/fixme and fix the others.

VolumeObject::volumeChanged is now emitted only when the volume actually changes.
Unavailable card profiles are no longer listed when built with PulseAudio >= 5.0.

Diffs (updated)
-----

  src/card.cpp 2e251a7 
  src/context.cpp 115c8a7 
  src/pulseaudio.cpp 1488784 
  src/volumeobject.h c64a964 

Diff: https://git.reviewboard.kde.org/r/127498/diff/

Testing
-------

Thanks,

David Rosca

--===============3560768227591757378==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127498/">https://git.reviewboard.kde.org/r/127498/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated March 26, 2016, 9:07 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix logic for volume changes - pa_cvolume_equal only compares \
pointers</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Change some warnings to todo/fixme and fix the \
others.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">VolumeObject::volumeChanged is now emitted only when \
the volume actually changes. Unavailable card profiles are no longer listed when \
built with PulseAudio &gt;= 5.0.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/card.cpp <span style="color: grey">(2e251a7)</span></li>

 <li>src/context.cpp <span style="color: grey">(115c8a7)</span></li>

 <li>src/pulseaudio.cpp <span style="color: grey">(1488784)</span></li>

 <li>src/volumeobject.h <span style="color: grey">(c64a964)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127498/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3560768227591757378==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 