'Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2016-03-31 2:54:22
Message-ID: 20160331025422.12706.237 () mimi ! kde ! org
[Download RAW message or body]

--===============4827024622722237005==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/
-----------------------------------------------------------

(Updated March 30, 2016, 7:54 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin Klapetek to \
branch master.

Bugs: 360683
    http://bugs.kde.org/show_bug.cgi?id=360683

Repository: plasma-framework

Description
-------

This removes some old cruft that is not really used and serves
basically only as a bool property for checking if it's null and
wheter it equals the last activated date.

This can be done without it by simply resetting the current selected
date (another property) to "today".

I decided to leave the useless property in for the time being
to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).

Diffs
-----

  src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f 
  src/declarativeimports/calendar/qml/MonthView.qml 76c605a 

Diff: https://git.reviewboard.kde.org/r/127455/diff/

Testing
-------

Selection is properly cleared.

Thanks,

Martin Klapetek

--===============4827024622722237005==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127455/">https://git.reviewboard.kde.org/r/127455/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated March 30, 2016, 7:54 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin \
Klapetek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=360683">360683</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This removes some old cruft that is not really used \
and serves basically only as a bool property for checking if it's null and
wheter it equals the last activated date.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This can be done without it by simply resetting the \
current selected date (another property) to "today".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I decided to leave the useless property in for the \
time being to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Selection is properly cleared.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/calendar/qml/DayDelegate.qml <span style="color: \
grey">(6877150)</span></li>

 <li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(8248a8f)</span></li>

 <li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(76c605a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127455/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4827024622722237005==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 