--===============0181971484765759573== Content-Type: multipart/alternative; boundary="===============4827024622722237005==" --===============4827024622722237005== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127455/ ----------------------------------------------------------- (Updated March 30, 2016, 7:54 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin Klapetek to branch master. Bugs: 360683 http://bugs.kde.org/show_bug.cgi?id=360683 Repository: plasma-framework Description ------- This removes some old cruft that is not really used and serves basically only as a bool property for checking if it's null and wheter it equals the last activated date. This can be done without it by simply resetting the current selected date (another property) to "today". I decided to leave the useless property in for the time being to allow for some buffer time between the -workspace and -framework release so that it does not throw errors (ie. if distros will ship 5.6 + p-f 5.21). Diffs ----- src/declarativeimports/calendar/qml/DayDelegate.qml 6877150 src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f src/declarativeimports/calendar/qml/MonthView.qml 76c605a Diff: https://git.reviewboard.kde.org/r/127455/diff/ Testing ------- Selection is properly cleared. Thanks, Martin Klapetek --===============4827024622722237005== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127455/

This change has been marked as submitted.

Review request for Plasma.
By Martin Klapetek.

Updated March 30, 2016, 7:54 p.m.

Changes

Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin Klapetek to branch master.
Bugs: 360683
Repository: plasma-framework

Description 

This removes some old cruft that is not really used and serves
basically only as a bool property for checking if it's null and
wheter it equals the last activated date.


This can be done without it by simply resetting the current selected
date (another property) to "today".


I decided to leave the useless property in for the time being
to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).

Testing 

Selection is properly cleared.

Diffs

  • src/declarativeimports/calendar/qml/DayDelegate.qml (6877150)
  • src/declarativeimports/calendar/qml/DaysCalendar.qml (8248a8f)
  • src/declarativeimports/calendar/qml/MonthView.qml (76c605a)

View Diff
--===============4827024622722237005==-- --===============0181971484765759573== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0181971484765759573==--