[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127492: KCM: Add possibility to move stream to other devices
From:       Thomas Pfeiffer <colomar () autistici ! org>
Date:       2016-03-25 19:46:35
Message-ID: 20160325194635.21226.58276 () mimi ! kde ! org
[Download RAW message or body]

--===============4689661117129781255==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote:
> > Two questions:
> > 1. If there is only one device, are the comoboxes hidden (they should be)?
> > 2. If I change the default device, are all streams automatically switched to that \
> > device?
> 
> David Rosca wrote:
> 1. Yes
> 2. No, it just sets the pulseaudio default sink/source. It is then used as fallback \
> device (when stream's device disappears, it will move to default device) and \
> probably also for new streams. 
> I also plan to make the global shortcut to change/mute volume and osd to only work \
> with default device.

1. Good
2. A bit of a problem. Or rather, it means we have to re-think some things. The \
problem is that currently we make the more common scenario (just switching all audio \
to a different device) more complicated to do than the more advanced scenario (moving \
individual streams).

I know that in theory, PulseAudio should be smart enough to just switch all audio to \
a newly plugged-in or switched-on device, but from my own experience I can say that \
this automatism doesn't always work. So for example if I have my TV connected to \
HDMI, I want all audio to go through my speakers when the TV is off. When I switch \
the TV on, though, it's more likely that I just want all audio to go through it \
instead of having to switch individual streams. Switching individual streams is a \
nice feature, but only useful for rather advanced setups. So we should keep it, but \
we need a way to move all output to a different device easier.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127492/#review93996
-----------------------------------------------------------


On March 25, 2016, 4:48 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127492/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 4:48 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Add combobox next to mute button with available devices.
> 
> 
> Diffs
> -----
> 
> src/kcm/package/contents/ui/DeviceComboBox.qml PRE-CREATION 
> src/kcm/package/contents/ui/SinkInputView.qml PRE-CREATION 
> src/kcm/package/contents/ui/SourceOutputView.qml PRE-CREATION 
> src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e 
> src/kcm/package/contents/ui/StreamView.qml b08c87a 
> src/kcm/package/contents/ui/main.qml 3360201 
> 
> Diff: https://git.reviewboard.kde.org/r/127492/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160325_142736.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png
>  
> 
> Thanks,
> 
> David Rosca
> 
> 


--===============4689661117129781255==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127492/">https://git.reviewboard.kde.org/r/127492/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 25th, 2016, 7:24 p.m. UTC, <b>Thomas \
Pfeiffer</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Two questions: 1. If there is only one device, are the \
comoboxes hidden (they should be)? 2. If I change the default device, are all streams \
automatically switched to that device?</p></pre>  </blockquote>




 <p>On March 25th, 2016, 7:30 p.m. UTC, <b>David Rosca</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Yes</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">No, it just sets the \
pulseaudio default sink/source. It is then used as fallback device (when stream's \
device disappears, it will move to default device) and probably also for new \
streams.</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I also plan to make the global shortcut to change/mute \
volume and osd to only work with default device.</p></pre>  </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Good</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">A bit of a problem. Or \
rather, it means we have to re-think some things. The problem is that currently we \
make the more common scenario (just switching all audio to a different device) more \
complicated to do than the more advanced scenario (moving individual streams).</li> \
</ol> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I know that in theory, PulseAudio should be smart \
enough to just switch all audio to a newly plugged-in or switched-on device, but from \
my own experience I can say that this automatism doesn't always work. So for example \
if I have my TV connected to HDMI, I want all audio to go through my speakers when \
the TV is off. When I switch the TV on, though, it's more likely that I just want all \
audio to go through it instead of having to switch individual streams. Switching \
individual streams is a nice feature, but only useful for rather advanced setups. So \
we should keep it, but we need a way to move all output to a different device \
easier.</p></pre> <br />










<p>- Thomas</p>


<br />
<p>On March 25th, 2016, 4:48 p.m. UTC, David Rosca wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>


<p style="color: grey;"><i>Updated March 25, 2016, 4:48 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add combobox next to mute button with available \
devices.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcm/package/contents/ui/DeviceComboBox.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kcm/package/contents/ui/SinkInputView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kcm/package/contents/ui/SourceOutputView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kcm/package/contents/ui/StreamListItem.qml <span style="color: \
grey">(7f1d69e)</span></li>

 <li>src/kcm/package/contents/ui/StreamView.qml <span style="color: \
grey">(b08c87a)</span></li>

 <li>src/kcm/package/contents/ui/main.qml <span style="color: \
grey">(3360201)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127492/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd \
-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png">Screenshot_20160325_142736.png</a></li>


</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============4689661117129781255==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic