From kde-panel-devel Fri Mar 25 19:46:35 2016 From: Thomas Pfeiffer Date: Fri, 25 Mar 2016 19:46:35 +0000 To: kde-panel-devel Subject: Re: Review Request 127492: KCM: Add possibility to move stream to other devices Message-Id: <20160325194635.21226.58276 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145893521907854 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7643778809506251327==" --===============7643778809506251327== Content-Type: multipart/alternative; boundary="===============4689661117129781255==" --===============4689661117129781255== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched to that device? > > David Rosca wrote: > 1. Yes > 2. No, it just sets the pulseaudio default sink/source. It is then used as fallback device (when stream's device disappears, it will move to default device) and probably also for new streams. > > I also plan to make the global shortcut to change/mute volume and osd to only work with default device. 1. Good 2. A bit of a problem. Or rather, it means we have to re-think some things. The problem is that currently we make the more common scenario (just switching all audio to a different device) more complicated to do than the more advanced scenario (moving individual streams). I know that in theory, PulseAudio should be smart enough to just switch all audio to a newly plugged-in or switched-on device, but from my own experience I can say that this automatism doesn't always work. So for example if I have my TV connected to HDMI, I want all audio to go through my speakers when the TV is off. When I switch the TV on, though, it's more likely that I just want all audio to go through it instead of having to switch individual streams. Switching individual streams is a nice feature, but only useful for rather advanced setups. So we should keep it, but we need a way to move all output to a different device easier. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93996 ----------------------------------------------------------- On March 25, 2016, 4:48 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127492/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 4:48 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-pa > > > Description > ------- > > Add combobox next to mute button with available devices. > > > Diffs > ----- > > src/kcm/package/contents/ui/DeviceComboBox.qml PRE-CREATION > src/kcm/package/contents/ui/SinkInputView.qml PRE-CREATION > src/kcm/package/contents/ui/SourceOutputView.qml PRE-CREATION > src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e > src/kcm/package/contents/ui/StreamView.qml b08c87a > src/kcm/package/contents/ui/main.qml 3360201 > > Diff: https://git.reviewboard.kde.org/r/127492/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot_20160325_142736.png > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png > > > Thanks, > > David Rosca > > --===============4689661117129781255== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/

On March 25th, 2016, 7:24 p.m. UTC, Thomas Pfeiffer wrote:

Two questions: 1. If there is only one device, are the comoboxes hidden (they should be)? 2. If I change the default device, are all streams automatically switched to that device?

On March 25th, 2016, 7:30 p.m. UTC, David Rosca wrote:

Yes
No, it just sets the pulseaudio default sink/source. It is then used as fallback device (when stream's device disappears, it will move to default device) and probably also for new streams.

I also plan to make the global shortcut to change/mute volume and osd to only work with default device.

Good
A bit of a problem. Or rather, it means we have to re-think some things. The problem is that currently we make the more common scenario (just switching all audio to a different device) more complicated to do than the more advanced scenario (moving individual streams).

I know that in theory, PulseAudio should be smart enough to just switch all audio to a newly plugged-in or switched-on device, but from my own experience I can say that this automatism doesn't always work. So for example if I have my TV connected to HDMI, I want all audio to go through my speakers when the TV is off. When I switch the TV on, though, it's more likely that I just want all audio to go through it instead of having to switch individual streams. Switching individual streams is a nice feature, but only useful for rather advanced setups. So we should keep it, but we need a way to move all output to a different device easier.

- Thomas

On March 25th, 2016, 4:48 p.m. UTC, David Rosca wrote:

Review request for Plasma and KDE Usability.

By David Rosca.

Updated March 25, 2016, 4:48 p.m.

Repository: plasma-pa

Description

Add combobox next to mute button with available devices.

Diffs

src/kcm/package/contents/ui/DeviceComboBox.qml (PRE-CREATION)
src/kcm/package/contents/ui/SinkInputView.qml (PRE-CREATION)
src/kcm/package/contents/ui/SourceOutputView.qml (PRE-CREATION)
src/kcm/package/contents/ui/StreamListItem.qml (7f1d69e)
src/kcm/package/contents/ui/StreamView.qml (b08c87a)
src/kcm/package/contents/ui/main.qml (3360201)

File Attachments

Screenshot_20160325_142736.png

--===============4689661117129781255==-- --===============7643778809506251327== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7643778809506251327==--